Re: [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests

[Stephen Smalley <sds@tycho.nsa.gov>]

On 1/20/20 6:11 AM, Richard Haines wrote:
> Test filesystem permissions using the fsopen(2), fsconfig(2), fsmount(2),
> fspick(2) and fsmount(2) api's introduced in kernel 5.2.
> 
> Also tests move_mount(2) using open_tree(2).
> 
> These tests use common code from tests/filesystem.
> 
> Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
> ---
<snip>
> diff --git a/tests/fs_filesystem/test b/tests/fs_filesystem/test
> new file mode 100755
> index 0000000..bda7fcf
> --- /dev/null
> +++ b/tests/fs_filesystem/test
> @@ -0,0 +1,833 @@
> +#!/usr/bin/perl
> +use Test::More;
<snip>
> +    # Set to '1' for testing 'hooks.c selinux_move_mount() FILE__MOUNTON'
> +    # Once kernel patch is mainline, add kernel version test.
> +    $test_move_mount = 0;
> +    if ($test_move_mount) {
> +        $test_count += 3;
> +    }

Wondering what we want the test above for test_move_mount to ultimately 
be.  It could be the first kernel version to include my fix.  That would 
avoid testsuite failures on kernels 5.2 through 5.5 assuming the fix is 
queued for 5.6.  On the other hand, it can be argued that the testsuite 
should fail on those kernels and the fix might end up going to stable 
and being back-ported to stable updates to those kernels, in which case 
testing those kernel versions may ultimately be useful.  Paul, what's 
your preference here?