From: Ondrej Mosnacek <omosnace@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Richard Haines <richard_c_haines@btinternet.com>,
SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests
Date: Fri, 24 Jan 2020 20:41:18 +0100 [thread overview]
Message-ID: <CAFqZXNtPVFV9F2E7ngzbfvTjMa2WKSVnCzhKN3RHMRHF-_FQSA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhTkhrdTPfhBMD=tBqVbCZBGdQS+fPHO1y4k79-CQrAPiw@mail.gmail.com>
On Fri, Jan 24, 2020 at 8:17 PM Paul Moore <paul@paul-moore.com> wrote:
> On Fri, Jan 24, 2020 at 10:12 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > On 1/20/20 6:11 AM, Richard Haines wrote:
> > > Test filesystem permissions using the fsopen(2), fsconfig(2), fsmount(2),
> > > fspick(2) and fsmount(2) api's introduced in kernel 5.2.
> > >
> > > Also tests move_mount(2) using open_tree(2).
> > >
> > > These tests use common code from tests/filesystem.
> > >
> > > Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
> >
> > Only question I have is whether we want to enable the move_mount test
> > unconditionally and let it break on kernels with the regression. Otherwise,
>
> Historically we haven't broken the test suite for older kernels, but I
> will admit that testing older kernels is no longer a priority for me.
I'd say if we expect the bug to be fixed in the stable branches of all
affected (& currently supported) kernel versions, we should just let
the test run unconditionally. I see little value in trying to match
the exact set of broken kernel versions. So my vote is to be strict
and if that turns out to cause too much trouble, we can always add
some check (and be more careful next time).
>
> > Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> >
> > > ---
> > > tests/Makefile | 6 +
> > > tests/fs_filesystem/.gitignore | 3 +
> > > tests/fs_filesystem/Makefile | 16 +
> > > tests/fs_filesystem/fs_common.c | 110 ++++
> > > tests/fs_filesystem/fs_common.h | 30 ++
> > > tests/fs_filesystem/fsmount.c | 89 ++++
> > > tests/fs_filesystem/fspick.c | 68 +++
> > > tests/fs_filesystem/move_mount.c | 76 +++
> > > tests/fs_filesystem/test | 833 +++++++++++++++++++++++++++++++
> > > 9 files changed, 1231 insertions(+)
> > > create mode 100644 tests/fs_filesystem/.gitignore
> > > create mode 100644 tests/fs_filesystem/Makefile
> > > create mode 100644 tests/fs_filesystem/fs_common.c
> > > create mode 100644 tests/fs_filesystem/fs_common.h
> > > create mode 100644 tests/fs_filesystem/fsmount.c
> > > create mode 100644 tests/fs_filesystem/fspick.c
> > > create mode 100644 tests/fs_filesystem/move_mount.c
> > > create mode 100755 tests/fs_filesystem/test
>
> --
> paul moore
> www.paul-moore.com
>
--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
prev parent reply other threads:[~2020-01-24 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 11:11 [PATCH 0/2] selinux-testsuite: Add fs*(2) API filesystem tests Richard Haines
2020-01-20 11:11 ` [PATCH 1/2] selinux-testsuite: Prepare for adding fs*(2) API tests Richard Haines
2020-01-24 15:12 ` Stephen Smalley
2020-01-20 11:11 ` [PATCH 2/2] selinux-testsuite: Add fs*(2) API filesystem tests Richard Haines
2020-01-21 18:56 ` Stephen Smalley
2020-01-24 15:13 ` Stephen Smalley
2020-01-24 19:17 ` Paul Moore
2020-01-24 19:25 ` Stephen Smalley
2020-01-24 19:41 ` Ondrej Mosnacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqZXNtPVFV9F2E7ngzbfvTjMa2WKSVnCzhKN3RHMRHF-_FQSA@mail.gmail.com \
--to=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=richard_c_haines@btinternet.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).