Re: [PATCH v2] scripts/ci: license as MIT

[Ondrej Mosnacek <omosnace@redhat.com>]

On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote:
> From: William Roberts <william.c.roberts@intel.com>
>
> License the ci scripts with a permissive, OSI approved license, such as
> MIT.
>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>
> ---
>  v1: Apache 2.0
>  v2: MIT
>
>  scripts/ci/LICENSE               | 7 +++++++
>  scripts/ci/fedora-test-runner.sh | 2 +-
>  scripts/ci/travis-kvm-setup.sh   | 2 +-
>  3 files changed, 9 insertions(+), 2 deletions(-)
>  create mode 100644 scripts/ci/LICENSE
>
> diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE
> new file mode 100644
> index 000000000000..6cd7b7924ef9
> --- /dev/null
> +++ b/scripts/ci/LICENSE
> @@ -0,0 +1,7 @@
> +Copyright <YEAR> <COPYRIGHT HOLDER>

You should probably put an actual year/name here?

> +
> +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
> +
> +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
> +
> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh
> index 569723387f6b..0aaba87c421b 100755
> --- a/scripts/ci/fedora-test-runner.sh
> +++ b/scripts/ci/fedora-test-runner.sh
> @@ -1,5 +1,5 @@
>  #!/usr/bin/env bash
> -
> +# SPDX-License-Identifier: MIT

As I said in the v1 thread, also the individual files should contain a
copyright line in addition to the SPDX line. See:
https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement

>  set -ev
>
>  #
> diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh
> index 8d4cfb79f7d7..2b5734178096 100755
> --- a/scripts/ci/travis-kvm-setup.sh
> +++ b/scripts/ci/travis-kvm-setup.sh
> @@ -1,5 +1,5 @@
>  #!/usr/bin/env bash
> -
> +# SPDX-License-Identifier: MIT
>  set -ev
>
>  TEST_RUNNER="scripts/ci/fedora-test-runner.sh"
> --
> 2.17.1
>

--
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel
Red Hat, Inc.