Re: [PATCH v2] scripts/ci: license as MIT

[Ondrej Mosnacek <omosnace@redhat.com>]

On Tue, Aug 4, 2020 at 4:36 PM William Roberts <bill.c.roberts@gmail.com> wrote:
> Sounds good.
>
> On Tue, Aug 4, 2020 at 9:35 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > On Mon, Aug 3, 2020 at 6:44 PM William Roberts <bill.c.roberts@gmail.com> wrote:
> > > On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > > >
> > > > On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote:
> > > > > From: William Roberts <william.c.roberts@intel.com>
> > > > >
> > > > > License the ci scripts with a permissive, OSI approved license, such as
> > > > > MIT.
> > > > >
> > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com>
> > > > > ---
> > > > >  v1: Apache 2.0
> > > > >  v2: MIT
> > > > >
> > > > >  scripts/ci/LICENSE               | 7 +++++++
> > > > >  scripts/ci/fedora-test-runner.sh | 2 +-
> > > > >  scripts/ci/travis-kvm-setup.sh   | 2 +-
> > > > >  3 files changed, 9 insertions(+), 2 deletions(-)
> > > > >  create mode 100644 scripts/ci/LICENSE
> > > > >
[...]
> > > > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh
> > > > > index 569723387f6b..0aaba87c421b 100755
> > > > > --- a/scripts/ci/fedora-test-runner.sh
> > > > > +++ b/scripts/ci/fedora-test-runner.sh
> > > > > @@ -1,5 +1,5 @@
> > > > >  #!/usr/bin/env bash
> > > > > -
> > > > > +# SPDX-License-Identifier: MIT
> > > >
> > > > As I said in the v1 thread, also the individual files should contain a
> > > > copyright line in addition to the SPDX line. See:
> > > > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement
> > >
> > > You don't actually need them and they just clutter the code and as a
> > > policy, I don't participate in adding to the problem of these big
> > > blocks
> > > of copyright statements that need to be maintained and grow per
> > > contributor. I can just drop the SPDX identifiers, as the LICENSE file
> > > applies to everything.
> > >
> > > With version control, the issues as described by that author are less
> > > of a problem. We can easily
> > > trace from whom, by how and when code was modified for any legal
> > > issues if they were to arise.
> > >
> > > We can just keep the LICENSE file, drop the SPDX identifiers and I
> > > would be 100% in-line with that libselinux is currently doing.
> >
> > I tend to disagree, but I can live with it if you want to leave it
> > out. So let me ACK this patch and I'll just remove the template
> > "Copyright" line from the LICENSE file when applying.
> >
> > Acked-by: Ondrej Mosnacek <omosnace@redhat.com>

Patch applied.

-- 
Ondrej Mosnacek
Software Engineer, Platform Security - SELinux kernel
Red Hat, Inc.