From: Paul Moore <paul@paul-moore.com>
To: dhowells@redhat.com
Cc: Richard Haines <richard_c_haines@btinternet.com>,
selinux@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [RFC PATCH 1/1] selinux: Add support for new key permissions
Date: Thu, 20 Feb 2020 19:03:40 -0500 [thread overview]
Message-ID: <CAHC9VhQ+pNTJjb=ipG_gsTSpv6-rEtWTL2sybrOnjyBJ+==2hw@mail.gmail.com> (raw)
In-Reply-To: <c5d6ae72-4f5d-fe41-c025-0eaa4616b7eb@tycho.nsa.gov>
On Thu, Feb 20, 2020 at 2:26 PM Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On 2/20/20 1:10 PM, Richard Haines wrote:
> > Add a new 'key_perms' policy capability and support for the additional
> > key permissions: inval, revoke, join, clear
> >
> > Also fixes JOIN -> LINK permission translation when policy
> > capability 'keys_perms' = 0;
> >
> > The current "setattr" perm name remains and is used for KEY_NEED_SETSEC.
> > This gives the following permissions for the 'key' class:
> >
> > create Create a key or keyring.
> > view View attributes.
> > read Read contents.
> > write Update or modify.
> > search Search (keyring) or find (key).
> > link Link a key into the keyring.
> > setattr kernel < current version: Change permissions on a keyring.
> > kernel >= current version: Set owner, group, ACL.
> > inval Invalidate key.
> > revoke Revoke key.
> > join Join keyring as session.
> > clear Clear a keyring.
> >
> > Signed-off-by: Richard Haines <richard_c_haines@btinternet.com>
> > Signed-off-by: David Howells <dhowells@redhat.com>
>
> What is this relative to? Didn't apply for me on any of keys-acl or
> keys-next or selinux-next.
>
> Regardless, we need to revert the original patch and create a new one
> that addresses the KEY_NEED_PARENT_JOIN issue I mentioned and that adds
> the key_perms capability in the right place in the first place, not
> apply a fix on top.
Yes, you really need to revert this patch David, I mentioned this some
time ago when the linux-next conflict appeared. Also, future patches
like this *really* need to go in via the SELinux tree, not the keys
tree, as they affect the SELinux kernel ABI and if they aren't merged
via the same tree lots of bad things can happen if we aren't careful.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-02-21 0:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 18:10 [RFC PATCH 0/1] selinux: Add support for new key permissions Richard Haines
2020-02-20 18:10 ` [RFC PATCH 1/1] " Richard Haines
[not found] ` <c5d6ae72-4f5d-fe41-c025-0eaa4616b7eb@tycho.nsa.gov>
2020-02-21 0:03 ` Paul Moore [this message]
2020-02-21 10:55 ` Richard Haines
2020-02-28 15:52 ` David Howells
2020-02-28 16:08 ` Paul Moore
2020-02-28 15:55 ` David Howells
2020-02-28 17:22 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQ+pNTJjb=ipG_gsTSpv6-rEtWTL2sybrOnjyBJ+==2hw@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=dhowells@redhat.com \
--cc=richard_c_haines@btinternet.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).