* [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
@ 2020-06-24 16:12 Ethan Edwards
2020-06-29 23:28 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Ethan Edwards @ 2020-06-24 16:12 UTC (permalink / raw)
To: paul; +Cc: stephen.smalley.work, selinux, linux-kernel
`sizeof buf` changed to `sizeof(buf)`
Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
---
security/selinux/ss/conditional.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
index 0cc7cdd58465..90a2f5927e55 100644
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
if (!booldatum)
return -ENOMEM;
- rc = next_entry(buf, fp, sizeof buf);
+ rc = next_entry(buf, fp, sizeof(buf));
if (rc)
goto err;
@@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
u32 i, len;
int rc;
- rc = next_entry(buf, fp, sizeof buf);
+ rc = next_entry(buf, fp, sizeof(buf));
if (rc)
return rc;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
2020-06-24 16:12 [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning Ethan Edwards
@ 2020-06-29 23:28 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2020-06-29 23:28 UTC (permalink / raw)
To: Ethan Edwards; +Cc: Stephen Smalley, selinux, linux-kernel
On Wed, Jun 24, 2020 at 12:13 PM Ethan Edwards
<ethancarteredwards@gmail.com> wrote:
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
> ---
> security/selinux/ss/conditional.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Merged into selinux/next but I rewrote the subject line to "selinux:
fixed a checkpatch warning with the sizeof macro" so that it fit
better with convention.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
@ 2020-07-09 13:11 Ethan Edwards
2020-07-09 18:09 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: Ethan Edwards @ 2020-07-09 13:11 UTC (permalink / raw)
To: paul; +Cc: stephen.smalley.work, selinux, linux-kernel
`sizeof buf` changed to `sizeof(buf)`
Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
---
security/selinux/ss/conditional.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
index 0cc7cdd58465..90a2f5927e55 100644
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
if (!booldatum)
return -ENOMEM;
- rc = next_entry(buf, fp, sizeof buf);
+ rc = next_entry(buf, fp, sizeof(buf));
if (rc)
goto err;
@@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
u32 i, len;
int rc;
- rc = next_entry(buf, fp, sizeof buf);
+ rc = next_entry(buf, fp, sizeof(buf));
if (rc)
return rc;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning
2020-07-09 13:11 Ethan Edwards
@ 2020-07-09 18:09 ` Paul Moore
0 siblings, 0 replies; 4+ messages in thread
From: Paul Moore @ 2020-07-09 18:09 UTC (permalink / raw)
To: Ethan Edwards; +Cc: Stephen Smalley, selinux, linux-kernel
On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards
<ethancarteredwards@gmail.com> wrote:
>
> `sizeof buf` changed to `sizeof(buf)`
>
> Signed-off-by: Ethan Edwards <ethancarteredwards@gmail.com>
> ---
> security/selinux/ss/conditional.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Why are you reposting this when I applied your original patch last week?
https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@mail.gmail.com
> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index 0cc7cdd58465..90a2f5927e55 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp)
> if (!booldatum)
> return -ENOMEM;
>
> - rc = next_entry(buf, fp, sizeof buf);
> + rc = next_entry(buf, fp, sizeof(buf));
> if (rc)
> goto err;
>
> @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp)
> u32 i, len;
> int rc;
>
> - rc = next_entry(buf, fp, sizeof buf);
> + rc = next_entry(buf, fp, sizeof(buf));
> if (rc)
> return rc;
>
> --
> 2.27.0
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-09 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 16:12 [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning Ethan Edwards
2020-06-29 23:28 ` Paul Moore
2020-07-09 13:11 Ethan Edwards
2020-07-09 18:09 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).