From: Matthew Hagan <mnhagan88@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Sam Ravnborg <sam@ravnborg.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series
Date: Sun, 13 Jun 2021 13:12:51 +0100 [thread overview]
Message-ID: <c7dc1a7f-40ed-2b32-f581-fb5793003e91@gmail.com> (raw)
Message-ID: <20210613121251.4SNqz7Hx8rZ_fJVV7HwSnizjv0oGkr3XDvEnPrqiM2c@z> (raw)
In-Reply-To: <20210613101658.3242777-3-mnhagan88@gmail.com>
On 13/06/2021 11:16, Matthew Hagan wrote:
> MX64 & MX64W Hardware info:
> - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
> - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
> - Storage: 1 GB (Micron MT29F8G08ABACA)
> - Networking: BCM58625 internal switch (5x 1GbE ports)
> - USB: 1x USB2.0
> - Serial: Internal header
> - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus
>
> This patch adds the Meraki MX64 series-specific bindings. Since some
> devices make use of the older A0 SoC, changes need to be made to
> accommodate this case, including removal of coherency options and
> modification to the secondary-boot-reg.
>
> Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 4 +
> .../boot/dts/bcm958625-meraki-kingpin.dtsi | 165 ++++++++++++++++++
> .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts | 45 +++++
> arch/arm/boot/dts/bcm958625-meraki-mx64.dts | 15 ++
> .../boot/dts/bcm958625-meraki-mx64w-a0.dts | 55 ++++++
> arch/arm/boot/dts/bcm958625-meraki-mx64w.dts | 23 +++
> 6 files changed, 307 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
> create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index f8f09c5066e7..83560b05f797 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -154,6 +154,10 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \
> bcm958525xmc.dtb \
> bcm958622hr.dtb \
> bcm958623hr.dtb \
> + bcm958625-meraki-mx64.dtb \
> + bcm958625-meraki-mx64-a0.dtb \
> + bcm958625-meraki-mx64w.dtb \
> + bcm958625-meraki-mx64w-a0.dtb \
> bcm958625hr.dtb \
> bcm988312hr.dtb \
> bcm958625k.dtb
> diff --git a/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
> new file mode 100644
> index 000000000000..107c2167a113
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
> @@ -0,0 +1,165 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Device Tree Bindings for Cisco Meraki MX64 series (Kingpin).
> + *
> + * Copyright (C) 2020-2021 Matthew Hagan <mnhagan88@gmail.com>
> + */
> +
> +#include "bcm958625-meraki-mx6x-common.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
dt-bindings/input/input.h should be included in
bcm958625-mx6x-common.dtsi.
dt-bindings/leds/common.h is already included in
bcm958625-mx6x-common.dtsi and isn't required here.
Likewise in bcm958625-meraki-alamo.dtsi
I will hold off on submitting a v4 until the preparatory SoC patches
are sorted out.
Matthew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-13 12:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 10:16 [PATCH v3 0/4] ARM: dts: NSP: add Meraki MX64/MX65 series Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` [PATCH v3 1/4] ARM: dts: NSP: Add common bindings for MX64/MX65 Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` [PATCH v3 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 12:12 ` Matthew Hagan [this message]
2021-06-13 12:12 ` Matthew Hagan
2021-06-13 12:12 ` Matthew Hagan
2021-06-13 10:16 ` [PATCH v3 3/4] ARM: dts: NSP: Add DT files for Meraki MX65 series Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` [PATCH v3 4/4] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65 Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-13 10:16 ` Matthew Hagan
2021-06-24 20:22 ` Rob Herring
2021-06-24 20:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7dc1a7f-40ed-2b32-f581-fb5793003e91@gmail.com \
--to=mnhagan88@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olteanv@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sbranden@broadcom.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).