soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
@ 2021-07-10 11:04 Stefan Wahren
  2021-07-10 11:04 ` Stefan Wahren
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Stefan Wahren @ 2021-07-10 11:04 UTC (permalink / raw)
  To: Nicolas Saenz Julienne
  Cc: Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, Arnd Bergmann, Olof Johansson,
	Saravana Kannan, Greg Kroah-Hartman, soc, linux-rpi-kernel,
	linux-arm-kernel, Stefan Wahren

The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 52a0400..d9abaae 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
 CONFIG_AB8500_USB=y
 CONFIG_KEYSTONE_USB_PHY=m
-CONFIG_NOP_USB_XCEIV=m
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_AM335X_PHY_USB=m
 CONFIG_TWL6030_USB=m
 CONFIG_USB_GPIO_VBUS=y
-- 
2.7.4


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
@ 2021-07-10 11:04 ` Stefan Wahren
  2021-07-11 21:27 ` Florian Fainelli
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Stefan Wahren @ 2021-07-10 11:04 UTC (permalink / raw)
  To: Nicolas Saenz Julienne
  Cc: Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list, Arnd Bergmann, Olof Johansson,
	Saravana Kannan, Greg Kroah-Hartman, soc, linux-rpi-kernel,
	linux-arm-kernel, Stefan Wahren

The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
been a "regression source" a lot of times. The last case is breakage of
USB mass storage boot has been commit e590474768f1 ("driver core: Set
fw_devlink=on by default") for multi_v7_defconfig. As long as
NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
endlessly and prevent booting from USB mass storage device. So make
the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 52a0400..d9abaae 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
 CONFIG_AB8500_USB=y
 CONFIG_KEYSTONE_USB_PHY=m
-CONFIG_NOP_USB_XCEIV=m
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_AM335X_PHY_USB=m
 CONFIG_TWL6030_USB=m
 CONFIG_USB_GPIO_VBUS=y
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
  2021-07-10 11:04 ` Stefan Wahren
@ 2021-07-11 21:27 ` Florian Fainelli
  2021-07-11 21:27   ` Florian Fainelli
  2021-07-12  5:04   ` Stefan Wahren
  2021-07-16 21:22 ` patchwork-bot+linux-soc
  2021-07-16 21:24 ` Arnd Bergmann
  3 siblings, 2 replies; 9+ messages in thread
From: Florian Fainelli @ 2021-07-11 21:27 UTC (permalink / raw)
  To: Stefan Wahren, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
	Olof Johansson, Saravana Kannan, Greg Kroah-Hartman, soc,
	linux-rpi-kernel, linux-arm-kernel



On 7/10/2021 4:04 AM, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Should not that be fixed somehow?

> 
> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 52a0400..d9abaae 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
>   CONFIG_USB_HSIC_USB3503=y
>   CONFIG_AB8500_USB=y
>   CONFIG_KEYSTONE_USB_PHY=m
> -CONFIG_NOP_USB_XCEIV=m
> +CONFIG_NOP_USB_XCEIV=y
>   CONFIG_AM335X_PHY_USB=m
>   CONFIG_TWL6030_USB=m
>   CONFIG_USB_GPIO_VBUS=y
> 

-- 
Florian

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-11 21:27 ` Florian Fainelli
@ 2021-07-11 21:27   ` Florian Fainelli
  2021-07-12  5:04   ` Stefan Wahren
  1 sibling, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2021-07-11 21:27 UTC (permalink / raw)
  To: Stefan Wahren, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
	Olof Johansson, Saravana Kannan, Greg Kroah-Hartman, soc,
	linux-rpi-kernel, linux-arm-kernel



On 7/10/2021 4:04 AM, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Should not that be fixed somehow?

> 
> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>   arch/arm/configs/multi_v7_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 52a0400..d9abaae 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y
>   CONFIG_USB_HSIC_USB3503=y
>   CONFIG_AB8500_USB=y
>   CONFIG_KEYSTONE_USB_PHY=m
> -CONFIG_NOP_USB_XCEIV=m
> +CONFIG_NOP_USB_XCEIV=y
>   CONFIG_AM335X_PHY_USB=m
>   CONFIG_TWL6030_USB=m
>   CONFIG_USB_GPIO_VBUS=y
> 

-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-11 21:27 ` Florian Fainelli
  2021-07-11 21:27   ` Florian Fainelli
@ 2021-07-12  5:04   ` Stefan Wahren
  2021-07-12  5:04     ` Stefan Wahren
  1 sibling, 1 reply; 9+ messages in thread
From: Stefan Wahren @ 2021-07-12  5:04 UTC (permalink / raw)
  To: Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
	Olof Johansson, Saravana Kannan, Greg Kroah-Hartman, soc,
	linux-rpi-kernel, linux-arm-kernel

Hi Florian,

Am 11.07.21 um 23:27 schrieb Florian Fainelli:
>
>
> On 7/10/2021 4:04 AM, Stefan Wahren wrote:
>> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
>> been a "regression source" a lot of times. The last case is breakage of
>> USB mass storage boot has been commit e590474768f1 ("driver core: Set
>> fw_devlink=on by default") for multi_v7_defconfig. As long as
>> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
>> endlessly and prevent booting from USB mass storage device. So make
>> the driver built-in as in bcm2835_defconfig and arm64/defconfig.
>
> Should not that be fixed somehow?

maybe that why send this bug report, but never get a feedback [1]

My spare time is too limited to fight multiple regressions on Raspberry
Pi, so i decided send at least this solution.

[1] - https://www.spinics.net/lists/arm-kernel/msg905208.html

>
>>
>> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
>> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---  


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-12  5:04   ` Stefan Wahren
@ 2021-07-12  5:04     ` Stefan Wahren
  0 siblings, 0 replies; 9+ messages in thread
From: Stefan Wahren @ 2021-07-12  5:04 UTC (permalink / raw)
  To: Florian Fainelli, Nicolas Saenz Julienne
  Cc: Ray Jui, Scott Branden, bcm-kernel-feedback-list, Arnd Bergmann,
	Olof Johansson, Saravana Kannan, Greg Kroah-Hartman, soc,
	linux-rpi-kernel, linux-arm-kernel

Hi Florian,

Am 11.07.21 um 23:27 schrieb Florian Fainelli:
>
>
> On 7/10/2021 4:04 AM, Stefan Wahren wrote:
>> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
>> been a "regression source" a lot of times. The last case is breakage of
>> USB mass storage boot has been commit e590474768f1 ("driver core: Set
>> fw_devlink=on by default") for multi_v7_defconfig. As long as
>> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
>> endlessly and prevent booting from USB mass storage device. So make
>> the driver built-in as in bcm2835_defconfig and arm64/defconfig.
>
> Should not that be fixed somehow?

maybe that why send this bug report, but never get a feedback [1]

My spare time is too limited to fight multiple regressions on Raspberry
Pi, so i decided send at least this solution.

[1] - https://www.spinics.net/lists/arm-kernel/msg905208.html

>
>>
>> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com>
>> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---  


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
  2021-07-10 11:04 ` Stefan Wahren
  2021-07-11 21:27 ` Florian Fainelli
@ 2021-07-16 21:22 ` patchwork-bot+linux-soc
  2021-07-16 21:24 ` Arnd Bergmann
  3 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+linux-soc @ 2021-07-16 21:22 UTC (permalink / raw)
  To: Stefan Wahren; +Cc: soc

Hello:

This patch was applied to soc/soc.git (refs/heads/arm/fixes):

On Sat, 10 Jul 2021 13:04:55 +0200 you wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.
> 
> [...]

Here is the summary with links:
  - ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
    https://git.kernel.org/soc/soc/c/ab37a7a890c1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
                   ` (2 preceding siblings ...)
  2021-07-16 21:22 ` patchwork-bot+linux-soc
@ 2021-07-16 21:24 ` Arnd Bergmann
  2021-07-16 21:24   ` Arnd Bergmann
  3 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2021-07-16 21:24 UTC (permalink / raw)
  To: Nicolas Saenz Julienne, Stefan Wahren
  Cc: Arnd Bergmann, Olof Johansson, linux-rpi-kernel, Scott Branden,
	Florian Fainelli, Greg Kroah-Hartman, bcm-kernel-feedback-list,
	Ray Jui, soc, linux-arm-kernel, Saravana Kannan

From: Arnd Bergmann <arnd@arndb.de>

On Sat, 10 Jul 2021 13:04:55 +0200, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Applied to arm/fixes, thanks!

[1/1] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
      commit: ab37a7a890c1176144a4c66ff3d51ef2c20ed486

       Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
  2021-07-16 21:24 ` Arnd Bergmann
@ 2021-07-16 21:24   ` Arnd Bergmann
  0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2021-07-16 21:24 UTC (permalink / raw)
  To: Nicolas Saenz Julienne, Stefan Wahren
  Cc: Arnd Bergmann, Olof Johansson, linux-rpi-kernel, Scott Branden,
	Florian Fainelli, Greg Kroah-Hartman, bcm-kernel-feedback-list,
	Ray Jui, soc, linux-arm-kernel, Saravana Kannan

From: Arnd Bergmann <arnd@arndb.de>

On Sat, 10 Jul 2021 13:04:55 +0200, Stefan Wahren wrote:
> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has
> been a "regression source" a lot of times. The last case is breakage of
> USB mass storage boot has been commit e590474768f1 ("driver core: Set
> fw_devlink=on by default") for multi_v7_defconfig. As long as
> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing
> endlessly and prevent booting from USB mass storage device. So make
> the driver built-in as in bcm2835_defconfig and arm64/defconfig.

Applied to arm/fixes, thanks!

[1/1] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in
      commit: ab37a7a890c1176144a4c66ff3d51ef2c20ed486

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-07-16 21:31 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-10 11:04 [PATCH] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in Stefan Wahren
2021-07-10 11:04 ` Stefan Wahren
2021-07-11 21:27 ` Florian Fainelli
2021-07-11 21:27   ` Florian Fainelli
2021-07-12  5:04   ` Stefan Wahren
2021-07-12  5:04     ` Stefan Wahren
2021-07-16 21:22 ` patchwork-bot+linux-soc
2021-07-16 21:24 ` Arnd Bergmann
2021-07-16 21:24   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).