soc.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	 Stefan Agner <stefan@agner.ch>,
	Linus Walleij <linus.walleij@linaro.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,  Olof Johansson <olof@lixom.net>,
	soc@kernel.org,  Russell King - ARM Linux <linux@armlinux.org.uk>,
	Abel Vesa <abel.vesa@nxp.com>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	 Giulio Benetti <giulio.benetti@benettiengineering.com>,
	 Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	linux-clk <linux-clk@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series
Date: Tue, 2 Nov 2021 20:17:19 -0300	[thread overview]
Message-ID: <CAOMZO5AxMXxDkNDqGJDhtepqSUxGRCWO+L=c67O==4fx66M7XQ@mail.gmail.com> (raw)
In-Reply-To: <20211102225701.98944-12-Mr.Bossman075@gmail.com>

On Tue, Nov 2, 2021 at 7:57 PM Jesse Taube <mr.bossman075@gmail.com> wrote:

>  static struct esdhc_soc_data usdhc_imx8qxp_data = {
>         .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> @@ -357,6 +363,7 @@ static const struct of_device_id imx_esdhc_dt_ids[] = {
>         { .compatible = "fsl,imx7ulp-usdhc", .data = &usdhc_imx7ulp_data, },
>         { .compatible = "fsl,imx8qxp-usdhc", .data = &usdhc_imx8qxp_data, },
>         { .compatible = "fsl,imx8mm-usdhc", .data = &usdhc_imx8mm_data, },
> +       { .compatible = "fsl,imxrt-usdhc", .data = &usdhc_imxrt_data, },

I thought Rob suggested to use the SoC name, so this would be:

{ .compatible = "fsl,imxrt1050-usdhc", .data = &usdhc_imxrt1050_data, },

The same applies to the other bindings in the series.

This way it would be possible to differentiate between future
supported i.MX RT devices.

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@gmail.com>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	 Stefan Agner <stefan@agner.ch>,
	Linus Walleij <linus.walleij@linaro.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	soc@kernel.org,  Russell King - ARM Linux <linux@armlinux.org.uk>,
	Abel Vesa <abel.vesa@nxp.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	 Giulio Benetti <giulio.benetti@benettiengineering.com>,
	 Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	linux-clk <linux-clk@vger.kernel.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series
Date: Tue, 2 Nov 2021 20:17:19 -0300	[thread overview]
Message-ID: <CAOMZO5AxMXxDkNDqGJDhtepqSUxGRCWO+L=c67O==4fx66M7XQ@mail.gmail.com> (raw)
Message-ID: <20211102231719.XYnsIYeBhRKBd4MV_JCE_CHAfK23gNAtK5-wI4L3pZI@z> (raw)
In-Reply-To: <20211102225701.98944-12-Mr.Bossman075@gmail.com>

On Tue, Nov 2, 2021 at 7:57 PM Jesse Taube <mr.bossman075@gmail.com> wrote:

>  static struct esdhc_soc_data usdhc_imx8qxp_data = {
>         .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> @@ -357,6 +363,7 @@ static const struct of_device_id imx_esdhc_dt_ids[] = {
>         { .compatible = "fsl,imx7ulp-usdhc", .data = &usdhc_imx7ulp_data, },
>         { .compatible = "fsl,imx8qxp-usdhc", .data = &usdhc_imx8qxp_data, },
>         { .compatible = "fsl,imx8mm-usdhc", .data = &usdhc_imx8mm_data, },
> +       { .compatible = "fsl,imxrt-usdhc", .data = &usdhc_imxrt_data, },

I thought Rob suggested to use the SoC name, so this would be:

{ .compatible = "fsl,imxrt1050-usdhc", .data = &usdhc_imxrt1050_data, },

The same applies to the other bindings in the series.

This way it would be possible to differentiate between future
supported i.MX RT devices.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-02 23:17 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 22:56 [PATCH v2 00/13] Add initial support for the i.MXRTxxxx SoC family starting from i.IMXRT1050 SoC Jesse Taube
2021-11-02 22:56 ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 01/13] ARM: imx: add initial support for i.MXRT10xx family Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 02/13] dt-bindings: pinctrl: add i.MXRT1050 pinctrl binding doc Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-03  1:20   ` Rob Herring
2021-11-03  1:20     ` Rob Herring
2021-11-03  1:38     ` Jesse Taube
2021-11-03  1:38       ` Jesse Taube
2021-11-09  1:07       ` Linus Walleij
2021-11-09  1:07         ` Linus Walleij
2021-11-09  2:59         ` Jesse Taube
2021-11-09  2:59           ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 03/13] ARM: dts: imxrt1050-pinfunc: Add pinctrl binding header Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 04/13] pinctrl: freescale: Add i.MXRT1050 pinctrl driver support Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 05/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-08 17:06     ` Rob Herring
2021-11-08 17:06       ` Rob Herring
2021-11-03  1:20   ` Rob Herring
2021-11-03  1:20     ` Rob Herring
2021-11-02 22:56 ` [PATCH v2 06/13] dt-bindings: imx: Add clock binding for i.MXRT1050 Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 07/13] clk: imx: Add initial support for i.MXRT clock driver Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 23:34   ` Fabio Estevam
2021-11-02 23:34     ` Fabio Estevam
2021-11-02 23:34     ` Fabio Estevam
2021-11-02 23:38     ` Jesse Taube
2021-11-02 23:38       ` Jesse Taube
2021-11-02 23:38       ` Jesse Taube
2021-11-05  9:42   ` Giulio Benetti
2021-11-05  9:42     ` Giulio Benetti
2021-11-02 22:56 ` [PATCH v2 08/13] dt-bindings: serial: fsl-lpuart: add i.MXRT compatible Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 09/13] tty: serial: fsl_lpuart: add i.MXRT support Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 10/13] dt-bindings: mmc: fsl-imx-esdhc: add i.MXRT compatible string Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 22:56 ` [PATCH v2 11/13] mmc: sdhci-esdhc-imx: Add sdhc support for i.MXRT series Jesse Taube
2021-11-02 22:56   ` Jesse Taube
2021-11-02 23:02   ` Giulio Benetti
2021-11-02 23:02     ` Giulio Benetti
2021-11-02 23:17   ` Fabio Estevam [this message]
2021-11-02 23:17     ` Fabio Estevam
2021-11-02 23:17     ` Fabio Estevam
2021-11-02 23:25     ` Jesse Taube
2021-11-02 23:25       ` Jesse Taube
2021-11-02 23:25       ` Jesse Taube
2021-11-02 23:30       ` Giulio Benetti
2021-11-02 23:30         ` Giulio Benetti
2021-11-04  1:05           ` Rob Herring
2021-11-04  1:05             ` Rob Herring
2021-11-04  1:05             ` Rob Herring
2021-11-04  2:30             ` Giulio Benetti
2021-11-04  2:30               ` Giulio Benetti
2021-11-04  2:30               ` Giulio Benetti
2021-11-02 23:30         ` Giulio Benetti
2021-11-03 17:51         ` Fabio Estevam
2021-11-03 17:51           ` Fabio Estevam
2021-11-03 17:51           ` Fabio Estevam
2021-11-03 19:10           ` Giulio Benetti
2021-11-03 19:10             ` Giulio Benetti
2021-11-03 19:10             ` Giulio Benetti
2021-11-03  2:19   ` Bough Chen
2021-11-03  2:19     ` Bough Chen
2021-11-03  2:19     ` Bough Chen
2021-11-23  3:13     ` Jesse Taube
2021-11-23  4:31       ` Bough Chen
2021-11-02 22:57 ` [PATCH v2 12/13] ARM: dts: imx: add i.MXRT1050-EVK support Jesse Taube
2021-11-02 22:57   ` Jesse Taube
2021-11-02 23:42   ` Fabio Estevam
2021-11-02 23:42     ` Fabio Estevam
2021-11-02 23:42     ` Fabio Estevam
2021-11-02 23:54     ` Jesse Taube
2021-11-02 23:54       ` Jesse Taube
2021-11-02 23:54       ` Jesse Taube
2021-11-03  2:19       ` Jesse Taube
2021-11-03  2:19         ` Jesse Taube
2021-11-03  2:19         ` Jesse Taube
2021-11-02 22:57 ` [PATCH v2 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig Jesse Taube
2021-11-02 22:57   ` Jesse Taube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5AxMXxDkNDqGJDhtepqSUxGRCWO+L=c67O==4fx66M7XQ@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=abel.vesa@nxp.com \
    --cc=adrian.hunter@intel.com \
    --cc=aisheng.dong@nxp.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mr.bossman075@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=stefan@agner.ch \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).