* [PATCH] usbnet: ipheth: fix connectivity with iOS 14 [not found] <CAAn0qaXmysJ9vx3ZEMkViv_B19ju-_ExN8Yn_uSefxpjS6g4Lw@mail.gmail.com> @ 2020-11-19 17:24 ` Yves-Alexis Perez 2020-11-20 9:15 ` Sergei Shtylyov 2020-11-21 22:03 ` Jakub Kicinski 0 siblings, 2 replies; 6+ messages in thread From: Yves-Alexis Perez @ 2020-11-19 17:24 UTC (permalink / raw) To: David S. Miller, Jakub Kicinski, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel Cc: Yves-Alexis Perez, Matti Vuorela, stable Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic or DNS resolution using the DNS service running in the device itself) works fine, but communication to endpoints further away doesn't work. Investigation on the matter shows that UDP and ICMP traffic from the tethered host is reaching the Internet at all. For TCP traffic there are exchanges between tethered host and server but packets are modified in transit leading to impossible communication. After some trials Matti Vuorela discovered that reducing the URB buffer size by two bytes restored the previous behavior. While a better solution might exist to fix the issue, since the protocol is not publicly documented and considering the small size of the fix, let's do that. Tested-by: Matti Vuorela <matti.vuorela@bitfactor.fi> Signed-off-by: Yves-Alexis Perez <corsac@corsac.net> Link: https://lore.kernel.org/linux-usb/CAAn0qaXmysJ9vx3ZEMkViv_B19ju-_ExN8Yn_uSefxpjS6g4Lw@mail.gmail.com/ Link: https://github.com/libimobiledevice/libimobiledevice/issues/1038 Cc: stable@vger.kernel.org --- drivers/net/usb/ipheth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c index b09b45382faf..207e59e74935 100644 --- a/drivers/net/usb/ipheth.c +++ b/drivers/net/usb/ipheth.c @@ -59,7 +59,7 @@ #define IPHETH_USBINTF_SUBCLASS 253 #define IPHETH_USBINTF_PROTO 1 -#define IPHETH_BUF_SIZE 1516 +#define IPHETH_BUF_SIZE 1514 #define IPHETH_IP_ALIGN 2 /* padding at front of URB */ #define IPHETH_TX_TIMEOUT (5 * HZ) -- 2.29.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14 2020-11-19 17:24 ` [PATCH] usbnet: ipheth: fix connectivity with iOS 14 Yves-Alexis Perez @ 2020-11-20 9:15 ` Sergei Shtylyov 2020-11-20 16:56 ` Yves-Alexis Perez 2020-11-21 22:03 ` Jakub Kicinski 1 sibling, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2020-11-20 9:15 UTC (permalink / raw) To: Yves-Alexis Perez, David S. Miller, Jakub Kicinski, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel Cc: Matti Vuorela, stable Hello! On 19.11.2020 20:24, Yves-Alexis Perez wrote: > Starting with iOS 14 released in September 2020, connectivity using the > personal hotspot USB tethering function of iOS devices is broken. > > Communication between the host and the device (for example ICMP traffic > or DNS resolution using the DNS service running in the device itself) > works fine, but communication to endpoints further away doesn't work. > > Investigation on the matter shows that UDP and ICMP traffic from the ^ "no" missing? > tethered host is reaching the Internet at all. For TCP traffic there are > exchanges between tethered host and server but packets are modified in > transit leading to impossible communication. > > After some trials Matti Vuorela discovered that reducing the URB buffer > size by two bytes restored the previous behavior. While a better > solution might exist to fix the issue, since the protocol is not > publicly documented and considering the small size of the fix, let's do > that. > > Tested-by: Matti Vuorela <matti.vuorela@bitfactor.fi> > Signed-off-by: Yves-Alexis Perez <corsac@corsac.net> > Link: https://lore.kernel.org/linux-usb/CAAn0qaXmysJ9vx3ZEMkViv_B19ju-_ExN8Yn_uSefxpjS6g4Lw@mail.gmail.com/ > Link: https://github.com/libimobiledevice/libimobiledevice/issues/1038 > Cc: stable@vger.kernel.org [...] MBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14 2020-11-20 9:15 ` Sergei Shtylyov @ 2020-11-20 16:56 ` Yves-Alexis Perez 0 siblings, 0 replies; 6+ messages in thread From: Yves-Alexis Perez @ 2020-11-20 16:56 UTC (permalink / raw) To: Sergei Shtylyov, David S. Miller, Jakub Kicinski, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel Cc: Matti Vuorela, stable On Fri, 2020-11-20 at 12:15 +0300, Sergei Shtylyov wrote: > > Investigation on the matter shows that UDP and ICMP traffic from the > ^ "no" missing? Yes indeed. Thanks and sorry for the typo. Regards, -- Yves-Alexis ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14 2020-11-19 17:24 ` [PATCH] usbnet: ipheth: fix connectivity with iOS 14 Yves-Alexis Perez 2020-11-20 9:15 ` Sergei Shtylyov @ 2020-11-21 22:03 ` Jakub Kicinski 2020-11-24 10:41 ` Yves-Alexis Perez 1 sibling, 1 reply; 6+ messages in thread From: Jakub Kicinski @ 2020-11-21 22:03 UTC (permalink / raw) To: Yves-Alexis Perez Cc: David S. Miller, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel, Matti Vuorela, stable On Thu, 19 Nov 2020 18:24:39 +0100 Yves-Alexis Perez wrote: > Starting with iOS 14 released in September 2020, connectivity using the > personal hotspot USB tethering function of iOS devices is broken. > > Communication between the host and the device (for example ICMP traffic > or DNS resolution using the DNS service running in the device itself) > works fine, but communication to endpoints further away doesn't work. > > Investigation on the matter shows that UDP and ICMP traffic from the > tethered host is reaching the Internet at all. For TCP traffic there are > exchanges between tethered host and server but packets are modified in > transit leading to impossible communication. > > After some trials Matti Vuorela discovered that reducing the URB buffer > size by two bytes restored the previous behavior. While a better > solution might exist to fix the issue, since the protocol is not > publicly documented and considering the small size of the fix, let's do > that. > > Tested-by: Matti Vuorela <matti.vuorela@bitfactor.fi> > Signed-off-by: Yves-Alexis Perez <corsac@corsac.net> > Link: https://lore.kernel.org/linux-usb/CAAn0qaXmysJ9vx3ZEMkViv_B19ju-_ExN8Yn_uSefxpjS6g4Lw@mail.gmail.com/ > Link: https://github.com/libimobiledevice/libimobiledevice/issues/1038 Applied to net with the typo fixed, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14 2020-11-21 22:03 ` Jakub Kicinski @ 2020-11-24 10:41 ` Yves-Alexis Perez 2020-11-24 16:39 ` Jakub Kicinski 0 siblings, 1 reply; 6+ messages in thread From: Yves-Alexis Perez @ 2020-11-24 10:41 UTC (permalink / raw) To: Jakub Kicinski Cc: David S. Miller, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel, Matti Vuorela, stable On Sat, 2020-11-21 at 14:03 -0800, Jakub Kicinski wrote: > Applied to net with the typo fixed, thanks! Thanks! Is there any chance it'll be in 5.10 or will it have to wait for the 5.11 merge window? Also it should be applied to all supported/stable kernels. I guess that'll have to wait until it's in Linus tree according [1] to but I'm unsure if I need to trigger the action myself or if Greg (or Dave, according to [2]) will do it. I looked at [3] and it seems that adding the CC: stable in my commit message maybe was an error because it's marked as a Failure, so if there's anything needed from me here, don't hesitate to ask. [1] https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html [2] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-can-i-tell-what-patches-are-queued-up-for-backporting-to-the-various-stable-releases [3] https://patchwork.kernel.org/bundle/netdev/stable/?state=* Regards, -- Yves-Alexis ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14 2020-11-24 10:41 ` Yves-Alexis Perez @ 2020-11-24 16:39 ` Jakub Kicinski 0 siblings, 0 replies; 6+ messages in thread From: Jakub Kicinski @ 2020-11-24 16:39 UTC (permalink / raw) To: Yves-Alexis Perez Cc: David S. Miller, Martin Habets, Luc Van Oostenryck, Shannon Nelson, Michael S. Tsirkin, linux-usb, netdev, linux-kernel, Matti Vuorela, stable On Tue, 24 Nov 2020 11:41:40 +0100 Yves-Alexis Perez wrote: > On Sat, 2020-11-21 at 14:03 -0800, Jakub Kicinski wrote: > > Applied to net with the typo fixed, thanks! > > Thanks! > > Is there any chance it'll be in 5.10 or will it have to wait for the 5.11 > merge window? It'll be in 5.10-rc6. > Also it should be applied to all supported/stable kernels. I guess that'll > have to wait until it's in Linus tree according [1] to but I'm unsure if I > need to trigger the action myself or if Greg (or Dave, according to [2]) will > do it. Dave (or someone helping him, like myself) will do it, probably around the time 5.10-rc6 is released. > I looked at [3] and it seems that adding the CC: stable in my commit message > maybe was an error because it's marked as a Failure, so if there's anything > needed from me here, don't hesitate to ask. No worries, I stripped the CC and put the patch in Dave's stable queue. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-24 16:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CAAn0qaXmysJ9vx3ZEMkViv_B19ju-_ExN8Yn_uSefxpjS6g4Lw@mail.gmail.com> 2020-11-19 17:24 ` [PATCH] usbnet: ipheth: fix connectivity with iOS 14 Yves-Alexis Perez 2020-11-20 9:15 ` Sergei Shtylyov 2020-11-20 16:56 ` Yves-Alexis Perez 2020-11-21 22:03 ` Jakub Kicinski 2020-11-24 10:41 ` Yves-Alexis Perez 2020-11-24 16:39 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).