* [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition [not found] <20220506171534.99509-1-glebfm@altlinux.org> @ 2022-05-06 17:24 ` Gleb Fotengauer-Malinovskiy 2022-05-07 7:05 ` Greg KH 0 siblings, 1 reply; 3+ messages in thread From: Gleb Fotengauer-Malinovskiy @ 2022-05-06 17:24 UTC (permalink / raw) To: Johannes Berg, Kalle Valo, linux-wireless, linux-kernel Cc: Gleb Fotengauer-Malinovskiy, stable Fixes: 54f586a91532 ("rfkill: make new event layout opt-in") Cc: stable@vger.kernel.org # 5.11+ Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> --- include/uapi/linux/rfkill.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/rfkill.h b/include/uapi/linux/rfkill.h index 283c5a7b3f2c..db6c8588c1d0 100644 --- a/include/uapi/linux/rfkill.h +++ b/include/uapi/linux/rfkill.h @@ -184,7 +184,7 @@ struct rfkill_event_ext { #define RFKILL_IOC_NOINPUT 1 #define RFKILL_IOCTL_NOINPUT _IO(RFKILL_IOC_MAGIC, RFKILL_IOC_NOINPUT) #define RFKILL_IOC_MAX_SIZE 2 -#define RFKILL_IOCTL_MAX_SIZE _IOW(RFKILL_IOC_MAGIC, RFKILL_IOC_EXT_SIZE, __u32) +#define RFKILL_IOCTL_MAX_SIZE _IOW(RFKILL_IOC_MAGIC, RFKILL_IOC_MAX_SIZE, __u32) /* and that's all userspace gets */ -- glebfm ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition 2022-05-06 17:24 ` [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition Gleb Fotengauer-Malinovskiy @ 2022-05-07 7:05 ` Greg KH 2022-05-07 8:45 ` Dmitry V. Levin 0 siblings, 1 reply; 3+ messages in thread From: Greg KH @ 2022-05-07 7:05 UTC (permalink / raw) To: Gleb Fotengauer-Malinovskiy Cc: Johannes Berg, Kalle Valo, linux-wireless, linux-kernel, stable On Fri, May 06, 2022 at 05:24:54PM +0000, Gleb Fotengauer-Malinovskiy wrote: > Fixes: 54f586a91532 ("rfkill: make new event layout opt-in") > Cc: stable@vger.kernel.org # 5.11+ > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> > --- No changelog text at all? I know I don't take patches like that, maybe other subsystem maintainers are more lax? Please provide a changelog... thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition 2022-05-07 7:05 ` Greg KH @ 2022-05-07 8:45 ` Dmitry V. Levin 0 siblings, 0 replies; 3+ messages in thread From: Dmitry V. Levin @ 2022-05-07 8:45 UTC (permalink / raw) To: Greg KH Cc: Gleb Fotengauer-Malinovskiy, Johannes Berg, Kalle Valo, linux-wireless, linux-kernel, stable On Sat, May 07, 2022 at 09:05:57AM +0200, Greg KH wrote: > On Fri, May 06, 2022 at 05:24:54PM +0000, Gleb Fotengauer-Malinovskiy wrote: > > Fixes: 54f586a91532 ("rfkill: make new event layout opt-in") > > Cc: stable@vger.kernel.org # 5.11+ > > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> > > --- > > No changelog text at all? I know I don't take patches like that, maybe > other subsystem maintainers are more lax? > > Please provide a changelog... The definition of RFKILL_IOCTL_MAX_SIZE introduced by commit 54f586a91532 is unusable since it is based on RFKILL_IOC_EXT_SIZE which has not been defined. Fix that by replacing the undefined constant with the constant which is intended to be used in this definition. Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> -- ldv ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-07 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220506171534.99509-1-glebfm@altlinux.org>
2022-05-06 17:24 ` [PATCH v2] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request definition Gleb Fotengauer-Malinovskiy
2022-05-07 7:05 ` Greg KH
2022-05-07 8:45 ` Dmitry V. Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).