* [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo
@ 2023-03-30 5:16 Nobuhiro Iwamatsu
2023-04-03 13:10 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2023-03-30 5:16 UTC (permalink / raw)
To: stable; +Cc: gregkh, sashal, Dan Carpenter, Alan Stern, Nobuhiro Iwamatsu
From: Dan Carpenter <dan.carpenter@oracle.com>
commit 0709831a50d31b3caf2237e8d7fe89e15b0d919d upstream.
The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
a no-op because of the & vs | typo. This bug predates git and it was
only discovered using static analysis so it must not affect too many
people in real life.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
---
drivers/usb/host/ohci-pxa27x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
index 3e247495973591..7679fb583e4161 100644
--- a/drivers/usb/host/ohci-pxa27x.c
+++ b/drivers/usb/host/ohci-pxa27x.c
@@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
uhcrhda |= RH_A_NPS;
break;
case PMM_GLOBAL_MODE:
- uhcrhda &= ~(RH_A_NPS & RH_A_PSM);
+ uhcrhda &= ~(RH_A_NPS | RH_A_PSM);
break;
case PMM_PERPORT_MODE:
uhcrhda &= ~(RH_A_NPS);
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo
2023-03-30 5:16 [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo Nobuhiro Iwamatsu
@ 2023-04-03 13:10 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-04-03 13:10 UTC (permalink / raw)
To: Nobuhiro Iwamatsu; +Cc: stable, sashal, Dan Carpenter, Alan Stern
On Thu, Mar 30, 2023 at 02:16:49PM +0900, Nobuhiro Iwamatsu wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> commit 0709831a50d31b3caf2237e8d7fe89e15b0d919d upstream.
>
> The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
> a no-op because of the & vs | typo. This bug predates git and it was
> only discovered using static analysis so it must not affect too many
> people in real life.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
> drivers/usb/host/ohci-pxa27x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-03 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 5:16 [PATCH for 4.14, 4.19] usb: host: ohci-pxa27x: Fix and & vs | typo Nobuhiro Iwamatsu
2023-04-03 13:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).