From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
Stable@vger.kernel.org, jgross@suse.com
Subject: Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors
Date: Tue, 16 Nov 2021 08:44:52 +0100 [thread overview]
Message-ID: <29e1ea87-c2e3-f8b1-b843-a390ad280984@suse.com> (raw)
In-Reply-To: <20211115222719.2558207-1-sstabellini@kernel.org>
On 15.11.2021 23:27, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter),
> we goto out_error but we forget to reset xen_store_domain_type to
> XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls
> will still try to initialize xenstore resulting into a crash at boot.
>
> [ 2.479830] Call trace:
> [ 2.482314] xb_init_comms+0x18/0x150
> [ 2.486354] xs_init+0x34/0x138
> [ 2.489786] xenbus_probe+0x4c/0x70
> [ 2.498432] xenbus_probe_initcall+0x2c/0x7c
> [ 2.503944] do_one_initcall+0x54/0x1b8
> [ 2.507358] kernel_init_freeable+0x1ac/0x210
> [ 2.511617] kernel_init+0x28/0x130
> [ 2.516112] ret_from_fork+0x10/0x20
>
> Cc: <Stable@vger.kernel.org>
> Cc: jbeulich@suse.com
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
For the immediate purpose as described this looks okay, so
Reviewed-by: Jan Beulich <jbeulich@suse.com>
However, aren't there further pieces missing on this error patch:
- clearing of xenstored_ready in case it got set,
- rolling back xenstored_local_init() (XS_LOCAL) and xen_remap()
(XS_HVM).
And shouldn't xs_init() failure when called from xenbus_probe()
also result in the driver not giving the appearance of being usable?
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -909,7 +909,7 @@ static struct notifier_block xenbus_resume_nb = {
>
> static int __init xenbus_init(void)
> {
> - int err = 0;
> + int err;
> uint64_t v = 0;
> xen_store_domain_type = XS_UNKNOWN;
>
Minor remark: You may want to take the opportunity and add the
missing blank line here to visually separate the assignment from
the declarations.
Jan
next prev parent reply other threads:[~2021-11-16 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 22:27 [PATCH v2] xen: don't continue xenstore initialization in case of errors Stefano Stabellini
2021-11-16 7:44 ` Jan Beulich [this message]
2021-11-16 20:41 ` Stefano Stabellini
2021-11-17 16:05 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e1ea87-c2e3-f8b1-b843-a390ad280984@suse.com \
--to=jbeulich@suse.com \
--cc=Stable@vger.kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).