From: Stefano Stabellini <sstabellini@kernel.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
Stable@vger.kernel.org, jgross@suse.com
Subject: Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors
Date: Tue, 16 Nov 2021 12:41:12 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2111161239180.1412361@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <29e1ea87-c2e3-f8b1-b843-a390ad280984@suse.com>
On Tue, 16 Nov 2021, Jan Beulich wrote:
> On 15.11.2021 23:27, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefano.stabellini@xilinx.com>
> >
> > In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter),
> > we goto out_error but we forget to reset xen_store_domain_type to
> > XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls
> > will still try to initialize xenstore resulting into a crash at boot.
> >
> > [ 2.479830] Call trace:
> > [ 2.482314] xb_init_comms+0x18/0x150
> > [ 2.486354] xs_init+0x34/0x138
> > [ 2.489786] xenbus_probe+0x4c/0x70
> > [ 2.498432] xenbus_probe_initcall+0x2c/0x7c
> > [ 2.503944] do_one_initcall+0x54/0x1b8
> > [ 2.507358] kernel_init_freeable+0x1ac/0x210
> > [ 2.511617] kernel_init+0x28/0x130
> > [ 2.516112] ret_from_fork+0x10/0x20
> >
> > Cc: <Stable@vger.kernel.org>
> > Cc: jbeulich@suse.com
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> For the immediate purpose as described this looks okay, so
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Thank you!
> However, aren't there further pieces missing on this error patch:
> - clearing of xenstored_ready in case it got set,
> - rolling back xenstored_local_init() (XS_LOCAL) and xen_remap()
> (XS_HVM).
> And shouldn't xs_init() failure when called from xenbus_probe()
> also result in the driver not giving the appearance of being usable?
I prioritized this patch because I have a direct test case for this
issue and I can see that this patch solves it. But what you wrote is
true, and I can have a look in the following weeks.
> > --- a/drivers/xen/xenbus/xenbus_probe.c
> > +++ b/drivers/xen/xenbus/xenbus_probe.c
> > @@ -909,7 +909,7 @@ static struct notifier_block xenbus_resume_nb = {
> >
> > static int __init xenbus_init(void)
> > {
> > - int err = 0;
> > + int err;
> > uint64_t v = 0;
> > xen_store_domain_type = XS_UNKNOWN;
> >
>
> Minor remark: You may want to take the opportunity and add the
> missing blank line here to visually separate the assignment from
> the declarations.
>
> Jan
>
next prev parent reply other threads:[~2021-11-16 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 22:27 [PATCH v2] xen: don't continue xenstore initialization in case of errors Stefano Stabellini
2021-11-16 7:44 ` Jan Beulich
2021-11-16 20:41 ` Stefano Stabellini [this message]
2021-11-17 16:05 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2111161239180.1412361@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=Stable@vger.kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).