From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>, jgross@suse.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@xilinx.com>,
Stable@vger.kernel.org, jbeulich@suse.com
Subject: Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors
Date: Wed, 17 Nov 2021 11:05:57 -0500 [thread overview]
Message-ID: <ed47fcdb-f841-65e6-be70-a12303ac153e@oracle.com> (raw)
In-Reply-To: <20211115222719.2558207-1-sstabellini@kernel.org>
On 11/15/21 5:27 PM, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>
> In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter),
> we goto out_error but we forget to reset xen_store_domain_type to
> XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls
> will still try to initialize xenstore resulting into a crash at boot.
>
> [ 2.479830] Call trace:
> [ 2.482314] xb_init_comms+0x18/0x150
> [ 2.486354] xs_init+0x34/0x138
> [ 2.489786] xenbus_probe+0x4c/0x70
> [ 2.498432] xenbus_probe_initcall+0x2c/0x7c
> [ 2.503944] do_one_initcall+0x54/0x1b8
> [ 2.507358] kernel_init_freeable+0x1ac/0x210
> [ 2.511617] kernel_init+0x28/0x130
> [ 2.516112] ret_from_fork+0x10/0x20
>
> Cc: <Stable@vger.kernel.org>
> Cc: jbeulich@suse.com
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Applied to for-linus-5.16c
-boris
prev parent reply other threads:[~2021-11-17 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 22:27 [PATCH v2] xen: don't continue xenstore initialization in case of errors Stefano Stabellini
2021-11-16 7:44 ` Jan Beulich
2021-11-16 20:41 ` Stefano Stabellini
2021-11-17 16:05 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed47fcdb-f841-65e6-be70-a12303ac153e@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=Stable@vger.kernel.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).