* [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier
[not found] <1597043179-17903-1-git-send-email-rnayak@codeaurora.org>
@ 2020-08-13 4:28 ` Viresh Kumar
2020-08-19 23:56 ` Sasha Levin
2020-08-26 13:54 ` Sasha Levin
0 siblings, 2 replies; 5+ messages in thread
From: Viresh Kumar @ 2020-08-13 4:28 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd, Rajendra Nayak
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Rafael Wysocki, mka,
sibis, v5 . 3+,
Sajida Bhanu, Stephen Boyd, linux-kernel
From: Rajendra Nayak <rnayak@codeaurora.org>
dev_pm_opp_set_rate() can now be called with freq = 0 in order
to either drop performance or bandwidth votes or to disable
regulators on platforms which support them.
In such cases, a subsequent call to dev_pm_opp_set_rate() with
the same frequency ends up returning early because 'old_freq == freq'
Instead make it fall through and put back the dropped performance
and bandwidth votes and/or enable back the regulators.
Cc: v5.3+ <stable@vger.kernel.org> # v5.3+
Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
Reported-by: Sajida Bhanu <sbhanu@codeaurora.org>
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
[ Viresh: Don't skip clk_set_rate() and massaged changelog ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Hi Rajendra,
I wasn't able to test this stuff, please give it a try. I have
simplified your patch and cleaned up a bunch of stuff as well.
drivers/opp/core.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index bdb028c7793d..9668ea04cc80 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -934,10 +934,13 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
/* Return early if nothing to do */
if (old_freq == freq) {
- dev_dbg(dev, "%s: old/new frequencies (%lu Hz) are same, nothing to do\n",
- __func__, freq);
- ret = 0;
- goto put_opp_table;
+ if (!opp_table->required_opp_tables && !opp_table->regulators &&
+ !opp_table->paths) {
+ dev_dbg(dev, "%s: old/new frequencies (%lu Hz) are same, nothing to do\n",
+ __func__, freq);
+ ret = 0;
+ goto put_opp_table;
+ }
}
/*
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier
2020-08-13 4:28 ` [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier Viresh Kumar
@ 2020-08-19 23:56 ` Sasha Levin
2020-08-20 4:58 ` Viresh Kumar
2020-08-26 13:54 ` Sasha Levin
1 sibling, 1 reply; 5+ messages in thread
From: Sasha Levin @ 2020-08-19 23:56 UTC (permalink / raw)
To: Sasha Levin, Viresh Kumar, Rajendra Nayak, Viresh Kumar, Nishanth Menon
Cc: Viresh Kumar, linux-pm, stable
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2641 bytes --]
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: cd7ea582866f ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes").
The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58.
v5.8.1: Build OK!
v5.7.15: Build failed! Errors:
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
v5.4.58: Build failed! Errors:
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier
2020-08-19 23:56 ` Sasha Levin
@ 2020-08-20 4:58 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2020-08-20 4:58 UTC (permalink / raw)
To: Sasha Levin
Cc: Rajendra Nayak, Viresh Kumar, Nishanth Menon, linux-pm, stable
On 19-08-20, 23:56, Sasha Levin wrote:
> Hi
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag
> fixing commit: cd7ea582866f ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes").
>
> The bot has tested the following trees: v5.8.1, v5.7.15, v5.4.58.
>
> v5.8.1: Build OK!
> v5.7.15: Build failed! Errors:
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
>
> v5.4.58: Build failed! Errors:
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
>
>
> NOTE: The patch will not be queued to stable trees until it is upstream.
>
> How should we proceed with this patch?
We probably need to send different versions for those kernel versions.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier
2020-08-13 4:28 ` [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier Viresh Kumar
2020-08-19 23:56 ` Sasha Levin
@ 2020-08-26 13:54 ` Sasha Levin
2020-08-27 4:32 ` Viresh Kumar
1 sibling, 1 reply; 5+ messages in thread
From: Sasha Levin @ 2020-08-26 13:54 UTC (permalink / raw)
To: Sasha Levin, Viresh Kumar, Rajendra Nayak, Viresh Kumar, Nishanth Menon
Cc: Viresh Kumar, linux-pm, stable
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]
Hi
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag
fixing commit: cd7ea582866f ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes").
The bot has tested the following trees: v5.8.2, v5.7.16, v5.4.59.
v5.8.2: Build OK!
v5.7.16: Build failed! Errors:
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
v5.4.59: Build failed! Errors:
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier
2020-08-26 13:54 ` Sasha Levin
@ 2020-08-27 4:32 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2020-08-27 4:32 UTC (permalink / raw)
To: Sasha Levin
Cc: Rajendra Nayak, Viresh Kumar, Nishanth Menon, linux-pm, stable
On 26-08-20, 13:54, Sasha Levin wrote:
> Hi
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag
> fixing commit: cd7ea582866f ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes").
>
> The bot has tested the following trees: v5.8.2, v5.7.16, v5.4.59.
>
> v5.8.2: Build OK!
> v5.7.16: Build failed! Errors:
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:849:17: error: 'struct opp_table' has no member named 'paths'
>
> v5.4.59: Build failed! Errors:
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: ‘struct opp_table’ has no member named ‘paths’
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
> drivers/opp/core.c:847:17: error: 'struct opp_table' has no member named 'paths'
>
>
> NOTE: The patch will not be queued to stable trees until it is upstream.
>
> How should we proceed with this patch?
I have already sent the right fix for stable.
https://lore.kernel.org/lkml/31f315cf2b0c4afd60b07b7121058dcaa6e4afa1.1598260882.git.viresh.kumar@linaro.org/
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-27 4:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1597043179-17903-1-git-send-email-rnayak@codeaurora.org>
2020-08-13 4:28 ` [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier Viresh Kumar
2020-08-19 23:56 ` Sasha Levin
2020-08-20 4:58 ` Viresh Kumar
2020-08-26 13:54 ` Sasha Levin
2020-08-27 4:32 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).