* [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()
@ 2021-06-17 6:31 Nathan Chancellor
2021-06-18 22:54 ` James Smart
2021-06-19 2:32 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-06-17 6:31 UTC (permalink / raw)
To: James Smart, Ram Vegesna, James E.J. Bottomley, Martin K. Petersen
Cc: Nick Desaulniers, linux-scsi, target-devel, linux-kernel,
clang-built-linux, Nathan Chancellor
clang warns:
drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
(!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
~~~~~~^~~
buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.
Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Link: https://github.com/ClangBuiltLinux/linux/issues/1398
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/scsi/elx/efct/efct_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c
index ce4736c41564..5b508d49e5a5 100644
--- a/drivers/scsi/elx/efct/efct_hw.c
+++ b/drivers/scsi/elx/efct/efct_hw.c
@@ -1519,8 +1519,7 @@ efct_hw_command_cancel(struct efct_hw *hw)
struct efct_command_ctx, list_entry);
efc_log_debug(hw->os, "hung command %08x\n",
- !ctx ? U32_MAX :
- (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
+ !ctx ? U32_MAX : *((u32 *)ctx->buf));
spin_unlock_irqrestore(&hw->cmd_lock, flags);
rc = efct_hw_command_process(hw, -1, mqe, SLI4_BMBX_SIZE);
spin_lock_irqsave(&hw->cmd_lock, flags);
base-commit: ebc076b3eddc807729bd81f7bc48e798a3ddc477
--
2.32.0.93.g670b81a890
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()
2021-06-17 6:31 [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel() Nathan Chancellor
@ 2021-06-18 22:54 ` James Smart
2021-06-19 2:32 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-06-18 22:54 UTC (permalink / raw)
To: Nathan Chancellor, James Smart, Ram Vegesna,
James E.J. Bottomley, Martin K. Petersen
Cc: Nick Desaulniers, linux-scsi, target-devel, linux-kernel,
clang-built-linux
On 6/16/2021 11:31 PM, Nathan Chancellor wrote:
> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
> (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
> ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.
>
> Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1398
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/scsi/elx/efct/efct_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks!
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()
2021-06-17 6:31 [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel() Nathan Chancellor
2021-06-18 22:54 ` James Smart
@ 2021-06-19 2:32 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-06-19 2:32 UTC (permalink / raw)
To: Nathan Chancellor
Cc: James Smart, Ram Vegesna, James E.J. Bottomley,
Martin K. Petersen, Nick Desaulniers, linux-scsi, target-devel,
linux-kernel, clang-built-linux
Nathan,
> clang warns:
>
> drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
> 'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
> (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
> ~~~~~~^~~
>
> buf is an array in the middle of a struct so deferencing it is not a
> problem as long as ctx is not NULL. Eliminate the check, which fixes the
> warning.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 2:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 6:31 [PATCH] scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel() Nathan Chancellor
2021-06-18 22:54 ` James Smart
2021-06-19 2:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).