tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* b4 version 0.3.5 released
@ 2020-03-27 16:45 Konstantin Ryabitsev
  2020-03-27 17:34 ` [kernel.org users] " Martin K. Petersen
  0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-27 16:45 UTC (permalink / raw)
  To: tools, users

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Hello:

Version 0.3.5 is a minor point release in the stable-0.3.y branch.  
Notable changes compared to v0.3.4:

- Tweak b4.sh wrapper so it can also be symlinked
- Strip leading id: and rfc822msgid: bits from the message-id
- Warn when we are ignoring trailers due to From mismatch and allow to 
  force their application using the -S,--sloppy-trailers flag
- Ignore messages without plaintext content instead of crashing
- Disambiguate cached messages when running with --useproject
- Minor bugfixes

Thanks to the following people for their help:
- Greg Kroah-Hartman
- Jason Donenfeld
- Rob Herring
- Geert Uytterhoeven

To upgrade with pip:

pip install --user --upgrade b4

You can also run from the stable-0.3.y branch directly from checkout if 
you use the b4.sh wrapper.

Best regards,
Konstantin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 235 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kernel.org users] b4 version 0.3.5 released
  2020-03-27 16:45 b4 version 0.3.5 released Konstantin Ryabitsev
@ 2020-03-27 17:34 ` Martin K. Petersen
  2020-03-27 17:46   ` Konstantin Ryabitsev
       [not found]   ` <16003A554CE54555.17905@linux.kernel.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-03-27 17:34 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools, users


Hi Konstantin!

> Version 0.3.5 is a minor point release in the stable-0.3.y branch.  

I started noticing this a few commits back. Sometimes my SoB is being
added before the patch author's. The interesting thing is that it is
non-deterministic. I.e. if I run exactly the same b4 command several
times in a row, sometimes the ordering is correct, sometimes it's
reversed.

While repeating this in one terminal:

$ b4 am -s 20200327141954.955-1-ddiss@suse.de

I run this in another:

$ tail -F v3_20200327_ddiss_scsi_target_xcopy_performance.mbx | grep Signed-off
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
[...]
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[...]
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
[...]

I think I'm cursed!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kernel.org users] b4 version 0.3.5 released
  2020-03-27 17:34 ` [kernel.org users] " Martin K. Petersen
@ 2020-03-27 17:46   ` Konstantin Ryabitsev
       [not found]   ` <16003A554CE54555.17905@linux.kernel.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-27 17:46 UTC (permalink / raw)
  To: Martin K. Petersen; +Cc: tools, users

On Fri, Mar 27, 2020 at 01:34:20PM -0400, Martin K. Petersen wrote:
> 
> Hi Konstantin!
> 
> > Version 0.3.5 is a minor point release in the stable-0.3.y branch.  
> 
> I started noticing this a few commits back. Sometimes my SoB is being
> added before the patch author's. The interesting thing is that it is
> non-deterministic. I.e. if I run exactly the same b4 command several
> times in a row, sometimes the ordering is correct, sometimes it's
> reversed.

Dang it, I know why this is happening. I switched to using a set() 
instead of a list() when handling trailers in order to simplify 
duplicate tracking. Unfortunately, I forgot that the order in a set() is 
non-deterministic, so even if we sort the list first, the moment it 
becomes a set, we lose positioning information.

I'll put in a fix.

-K

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tools] [kernel.org users] b4 version 0.3.5 released
       [not found]   ` <16003A554CE54555.17905@linux.kernel.org>
@ 2020-03-27 18:04     ` Konstantin Ryabitsev
  2020-03-27 20:50       ` Martin K. Petersen
  0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ryabitsev @ 2020-03-27 18:04 UTC (permalink / raw)
  To: tools; +Cc: Martin K. Petersen, users

On Fri, Mar 27, 2020 at 01:46:39PM -0400, Konstantin Ryabitsev via Linux.Kernel.Org wrote:
> > I started noticing this a few commits back. Sometimes my SoB is 
> > being
> > added before the patch author's. The interesting thing is that it is
> > non-deterministic. I.e. if I run exactly the same b4 command several
> > times in a row, sometimes the ordering is correct, sometimes it's
> > reversed.
> 
> Dang it, I know why this is happening. I switched to using a set() 
> instead of a list() when handling trailers in order to simplify 
> duplicate tracking. Unfortunately, I forgot that the order in a set() is 
> non-deterministic, so even if we sort the list first, the moment it 
> becomes a set, we lose positioning information.
> 
> I'll put in a fix.

The latest commit (in master and stable-0.3.y) should fix this.

Best,
-K

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [tools] [kernel.org users] b4 version 0.3.5 released
  2020-03-27 18:04     ` [tools] " Konstantin Ryabitsev
@ 2020-03-27 20:50       ` Martin K. Petersen
  0 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2020-03-27 20:50 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: tools, Martin K. Petersen, users


Konstantin,

> The latest commit (in master and stable-0.3.y) should fix this.

No gremlins to be found. Thanks much!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-27 20:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27 16:45 b4 version 0.3.5 released Konstantin Ryabitsev
2020-03-27 17:34 ` [kernel.org users] " Martin K. Petersen
2020-03-27 17:46   ` Konstantin Ryabitsev
     [not found]   ` <16003A554CE54555.17905@linux.kernel.org>
2020-03-27 18:04     ` [tools] " Konstantin Ryabitsev
2020-03-27 20:50       ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).