u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request
@ 2021-12-15 16:47 Sean Anderson
  2021-12-15 16:47 ` [PATCH v2 2/2] clk: cdce9xxx: Add maintainer Sean Anderson
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Sean Anderson @ 2021-12-15 16:47 UTC (permalink / raw)
  To: u-boot; +Cc: Tero Kristo, Lukasz Majewski, Tom Rini, Sean Anderson

This xlate function just performs some checking. We can do this in
request() instead and use the default xlate.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

Changes in v2:
- Fix build error caused by mismatched function name

 drivers/clk/clk-cdce9xx.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c
index 6634b7b799..f23465d7e1 100644
--- a/drivers/clk/clk-cdce9xx.c
+++ b/drivers/clk/clk-cdce9xx.c
@@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val)
 	return ret;
 }
 
-static int cdce9xx_clk_of_xlate(struct clk *clk,
-				struct ofnode_phandle_args *args)
+static int cdce9xx_clk_request(struct clk *clk)
 {
 	struct cdce9xx_clk_data *data = dev_get_priv(clk->dev);
 
-	if (args->args_count != 1)
+	if (clk->id > data->chip->num_outputs)
 		return -EINVAL;
 
-	if (args->args[0] > data->chip->num_outputs)
-		return -EINVAL;
-
-	clk->id = args->args[0];
-
 	return 0;
 }
 
@@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = {
 };
 
 static const struct clk_ops cdce9xx_clk_ops = {
-	.of_xlate = cdce9xx_clk_of_xlate,
+	.request = cdce9xx_clk_request,
 	.get_rate = cdce9xx_clk_get_rate,
 	.set_rate = cdce9xx_clk_set_rate,
 };
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-01-15 20:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 16:47 [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request Sean Anderson
2021-12-15 16:47 ` [PATCH v2 2/2] clk: cdce9xxx: Add maintainer Sean Anderson
2021-12-16 13:17   ` Tero Kristo
2021-12-16 13:57     ` Sean Anderson
2021-12-16 14:07       ` Tero Kristo
2021-12-16 14:29         ` Sean Anderson
2021-12-16 13:06 ` [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request Tero Kristo
2022-01-15 20:40 ` (subset) " Sean Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).