From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>, U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: Please pull u-boot-marvell/master
Date: Sun, 1 Aug 2021 10:33:33 -0400 [thread overview]
Message-ID: <20210801143333.GM9379@bill-the-cat> (raw)
In-Reply-To: <20210801104649.tkfal5jykph5k2pk@pali>
[-- Attachment #1: Type: text/plain, Size: 2790 bytes --]
On Sun, Aug 01, 2021 at 12:46:49PM +0200, Pali Rohár wrote:
> On Sunday 01 August 2021 07:26:51 Stefan Roese wrote:
> > On 01.08.21 05:28, Tom Rini wrote:
> > > On Sat, Jul 31, 2021 at 12:04:01PM +0200, Stefan Roese wrote:
> > >
> > > > Hi Tom,
> > > >
> > > > please pull the next batch of Marvell MVEBU related patches. Here the
> > > > summary log:
> > >
> > > First off, I've applied the whole series to u-boot/master and pushed.
> > >
> > > Second, I see from:
> > > commit 5fce2875569d6e859443af7af3477c3aebfee383
> > > Author: Pali Rohár <pali@kernel.org>
> > > Date: Fri Jul 23 11:14:27 2021 +0200
> > >
> > > SPL: Add support for specifying offset between header and image
> > >
> > > That a number of boards are now doing:
> > > variscite_dart6ul: spl/u-boot-spl:all +144 spl/u-boot-spl:text +144
> > > spl-u-boot-spl: add: 3/0, grow: 2/-1 bytes: 142/-4 (138)
> > > function old new delta
> > > memmove - 42 +42
> > > spl_mmc_load 320 356 +36
> > > __aeabi_uidivmod - 24 +24
> > > __aeabi_idivmod - 24 +24
> > > spl_parse_image_header 24 40 +16
> > > board_init_r 220 216 -4
> > >
> > > Which I think is because we need to use do_div and so rather than '/' and '%'
> > > directly in the code. Thanks!
> >
> > Pali, could you please take a look at this?
>
> And what we can do here? 32-bit arm does not have 32-bit division
> instruction, so it is needed to use some sort of *idiv* function.
>
> do_div() is macro which is doing 64-bit division by using 32-bit C
> operations '/' and '%', therefore it does not help with anything as this
> code is doing 32-bit math (not 64-bit).
>
> Moreover in do_div() implementation is already check that first passed
> argument is of 64-bit type, so we cannot use it for 32-bit values.
>
> Also note that in files which are touched by this commit are already
> used 32-bit division operations via C '/' operator.
>
> So I really do not know what is expected to do here...
Thanks for checking. I saw block stuff and that typically does involve
a 64bit value somewhere along the way. So if the answer is:
- There's no 64-bit math here, really.
- There's no existing shift macros we can use instead (or that ends up
being larger!)
- There's no existing shift macros we just need to import from the
kernel.
Then we're good.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-08-01 14:33 UTC|newest]
Thread overview: 190+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 10:04 Please pull u-boot-marvell/master Stefan Roese
2021-08-01 3:28 ` Tom Rini
2021-08-01 5:26 ` Stefan Roese
2021-08-01 10:46 ` Pali Rohár
2021-08-01 14:33 ` Tom Rini [this message]
2021-08-01 14:46 ` Pali Rohár
-- strict thread matches above, loose matches on Subject: below --
2024-04-04 12:08 Stefan Roese
2024-04-06 0:42 ` Tom Rini
2024-03-05 10:35 Stefan Roese
2024-03-05 13:27 ` Tom Rini
2024-01-22 15:46 Stefan Roese
2024-01-22 16:00 ` Tom Rini
2024-01-10 14:47 Stefan Roese
2024-01-10 15:46 ` Tom Rini
2023-10-27 6:51 Stefan Roese
2023-10-28 0:50 ` Tom Rini
2023-10-20 12:51 Stefan Roese
2023-10-20 14:45 ` Tom Rini
2023-10-20 16:44 ` Stefan Roese
2023-10-20 16:54 ` Tom Rini
2023-10-20 16:55 ` Tom Rini
2023-10-16 14:50 Stefan Roese
2023-10-16 21:32 ` Tom Rini
2023-08-01 9:17 Stefan Roese
2023-08-01 15:57 ` Tom Rini
2023-07-13 14:03 Stefan Roese
2023-07-14 16:04 ` Tom Rini
2023-05-08 8:47 Stefan Roese
2023-05-08 17:39 ` Tom Rini
2023-05-03 9:18 Stefan Roese
2023-05-03 17:14 ` Tom Rini
2023-04-14 6:09 Stefan Roese
2023-04-15 5:07 ` Tom Rini
2023-03-06 11:52 Stefan Roese
2023-03-06 20:12 ` Tom Rini
2023-02-13 14:01 Stefan Roese
2023-02-13 16:28 ` Tom Rini
2023-01-26 9:26 Stefan Roese
2023-01-26 17:08 ` Tom Rini
2023-01-17 11:49 Stefan Roese
2023-01-17 13:20 ` Tom Rini
2023-01-02 10:49 Stefan Roese
2023-01-02 14:36 ` Tom Rini
2022-12-12 8:57 Stefan Roese
2022-12-12 15:43 ` Tom Rini
2022-11-07 8:24 Stefan Roese
2022-11-07 15:13 ` Tom Rini
2022-10-06 10:47 Stefan Roese
2022-10-06 14:25 ` Tom Rini
2022-09-26 11:59 Stefan Roese
2022-09-26 14:00 ` Tom Rini
2022-09-18 12:00 Stefan Roese
2022-09-18 12:34 ` Tom Rini
2022-09-13 10:26 Stefan Roese
2022-09-13 13:49 ` Tom Rini
2022-08-23 15:09 Stefan Roese
2022-08-24 13:52 ` Tom Rini
2022-08-09 11:43 Stefan Roese
2022-08-09 16:33 ` Tom Rini
2022-07-29 12:05 Stefan Roese
2022-07-29 14:31 ` Tom Rini
2022-07-21 12:28 Stefan Roese
2022-07-21 17:40 ` Tom Rini
2022-05-17 7:57 Stefan Roese
2022-05-18 23:52 ` Tom Rini
2022-05-04 9:26 Stefan Roese
2022-05-04 15:41 ` Tom Rini
2022-05-02 15:53 Stefan Roese
2022-05-03 15:06 ` Tom Rini
2022-04-21 14:18 Stefan Roese
2022-04-21 18:24 ` Tom Rini
2022-03-24 16:42 Stefan Roese
2022-03-24 21:23 ` Tom Rini
2022-03-16 9:52 Stefan Roese
2022-03-16 14:48 ` Tom Rini
2022-03-14 15:23 Stefan Roese
2022-03-14 16:19 ` Tom Rini
2022-03-04 12:27 Stefan Roese
2022-03-04 18:12 ` Tom Rini
2022-02-17 15:46 Stefan Roese
2022-02-17 18:56 ` Tom Rini
2022-02-10 8:21 Stefan Roese
2022-02-10 14:01 ` Tom Rini
2022-01-31 11:37 Stefan Roese
2022-01-31 15:21 ` Tom Rini
2022-01-20 16:31 Stefan Roese
2022-01-20 18:48 ` Tom Rini
2022-01-14 15:42 Stefan Roese
2022-01-14 17:26 ` Tom Rini
2022-01-05 17:27 Stefan Roese
2022-01-05 19:24 ` Tom Rini
2021-12-15 10:58 Stefan Roese
2021-12-15 13:39 ` Tom Rini
2021-11-30 13:42 Stefan Roese
2021-11-30 16:54 ` Tom Rini
2021-11-10 13:52 Stefan Roese
2021-11-10 19:11 ` Tom Rini
2021-11-03 7:49 Stefan Roese
2021-11-03 14:44 ` Tom Rini
2021-10-28 10:50 Stefan Roese
2021-10-28 14:47 ` Tom Rini
2021-10-21 7:53 Stefan Roese
2021-10-21 14:16 ` Tom Rini
2021-10-08 9:23 Stefan Roese
2021-10-08 13:56 ` Tom Rini
2021-09-29 7:47 Stefan Roese
2021-09-29 22:28 ` Tom Rini
2021-09-27 10:58 Stefan Roese
2021-09-27 12:52 ` Tom Rini
2021-09-10 12:05 Stefan Roese
2021-09-10 17:57 ` Tom Rini
2021-09-01 9:24 Stefan Roese
2021-09-01 14:12 ` Tom Rini
2021-08-11 8:30 Stefan Roese
2021-08-11 15:50 ` Tom Rini
2021-07-19 12:37 Stefan Roese
2021-07-19 20:44 ` Tom Rini
2021-07-15 10:36 Stefan Roese
2021-07-15 18:48 ` Tom Rini
2021-07-09 5:19 Stefan Roese
2021-07-10 1:08 ` Tom Rini
2021-06-15 8:11 Stefan Roese
2021-06-16 3:16 ` Tom Rini
2021-06-10 7:55 Stefan Roese
2021-06-10 17:27 ` Tom Rini
2021-06-04 13:15 Stefan Roese
2021-06-05 3:09 ` Tom Rini
2021-05-20 13:39 Stefan Roese
2021-05-21 14:07 ` Tom Rini
2021-05-13 10:21 Stefan Roese
2021-05-13 15:37 ` Tom Rini
2021-05-15 8:03 ` Stefan Roese
2021-05-15 12:07 ` Tom Rini
2021-04-29 6:47 Stefan Roese
2021-04-29 15:30 ` Tom Rini
2021-04-08 8:57 Stefan Roese
2021-04-08 19:35 ` Tom Rini
2021-03-12 9:02 Stefan Roese
2021-03-12 15:17 ` Tom Rini
2021-02-26 11:14 Stefan Roese
2021-02-26 17:40 ` Tom Rini
2021-02-08 11:41 Stefan Roese
2021-02-08 20:42 ` Tom Rini
2021-01-27 16:02 Stefan Roese
2021-01-27 19:22 ` Tom Rini
2020-12-28 10:40 Stefan Roese
2020-12-28 15:31 ` Tom Rini
2020-12-07 11:18 Stefan Roese
2020-12-07 22:09 ` Tom Rini
2020-10-29 14:31 Stefan Roese
2020-10-30 18:46 ` Tom Rini
2020-10-16 13:40 Stefan Roese
2020-10-16 22:02 ` Tom Rini
2020-10-14 8:19 Stefan Roese
2020-10-15 0:03 ` Tom Rini
2020-10-01 12:41 Stefan Roese
2020-10-01 22:10 ` Tom Rini
2020-09-24 10:40 Stefan Roese
2020-09-25 16:54 ` Tom Rini
2020-09-04 14:04 Stefan Roese
2020-09-04 16:49 ` Tom Rini
2020-08-31 13:12 Stefan Roese
2020-08-31 16:50 ` Tom Rini
2020-08-25 13:20 Stefan Roese
2020-08-26 1:22 ` Tom Rini
2020-08-13 12:24 Stefan Roese
2020-08-13 14:51 ` Tom Rini
2020-08-06 14:33 Stefan Roese
2020-08-06 18:28 ` Tom Rini
2020-08-08 14:42 ` Tom Rini
2020-07-09 8:42 Stefan Roese
2020-07-09 13:54 ` Tom Rini
2020-05-27 7:09 Stefan Roese
2020-05-27 15:59 ` Tom Rini
2020-05-04 6:54 Stefan Roese
2020-05-04 17:54 ` Tom Rini
2020-04-22 14:48 Stefan Roese
2020-04-22 18:34 ` Tom Rini
2020-04-23 5:04 ` Stefan Roese
2020-04-23 14:17 ` Joel Johnson
2020-04-14 11:28 Stefan Roese
2020-04-14 23:25 ` Tom Rini
2020-01-21 13:03 Stefan Roese
2020-01-21 13:11 ` Tom Rini
2020-01-21 13:19 ` Stefan Roese
2020-01-21 13:31 ` Baruch Siach
2020-01-21 13:32 ` Tom Rini
2020-01-21 13:33 ` Stefan Roese
2020-01-16 14:34 Stefan Roese
2020-01-16 21:02 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210801143333.GM9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).