Re: [PATCH 0/8] powerpc: mpc85xx: Fix and cleanup mpc85xx code

From: "Pali Rohár" <pali@kernel.org>
To: Sinan Akman <sinan@writeme.com>
Cc: Priyanka Jain <priyanka.jain@nxp.com>,
	Qiang Zhao <qiang.zhao@nxp.com>,
	Shengzhou Liu <Shengzhou.Liu@nxp.com>,
	Alexander Graf <agraf@csgraf.de>, Bin Meng <bmeng.cn@gmail.com>,
	Wolfgang Denk <wd@denx.de>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 0/8] powerpc: mpc85xx: Fix and cleanup mpc85xx code
Date: Tue, 5 Apr 2022 19:17:43 +0200	[thread overview]
Message-ID: <20220405171743.6uknhync5n7gsm2p@pali> (raw)
In-Reply-To: <67dbca1d-bc36-f4ae-02e8-0959a804cb62@writeme.com>

On Tuesday 05 April 2022 13:03:15 Sinan Akman wrote:
> 
>   Hi Pali
> 
> On 2022-04-05 9:12 a.m., Pali Rohár wrote:
> > This patch series fixes support for CONFIG_OF_SEPARATE option, cleanup
> > linker scripts and change code so TEXT_BASE address is set o expected value.
> > 
> > Tested on P2020 based board.
> > 
> > Pali Rohár (8):
> >    powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support
> >    powerpc: mpc85xx: Remove duplicate u-boot-nand.lds
> >    powerpc: mpc85xx: Remove u-boot-nand_spl.lds
> >    powerpc: mpc85xx: Remove useless SIZEOF_HEADERS and .interp from ld
> >      script
> >    powerpc: mpc85xx: Put bss after image when not including reset vector
> >    powerpc: mpc85xx: Define linker sections in ascending order
> >    powerpc: mpc85xx: Set TEXT_BASE addresses to real base values
> >    board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros
> > 
> >   arch/powerpc/cpu/mpc85xx/start.S             |  4 +-
> >   arch/powerpc/cpu/mpc85xx/u-boot-nand.lds     | 97 --------------------
> >   arch/powerpc/cpu/mpc85xx/u-boot-nand_spl.lds | 68 --------------
> >   arch/powerpc/cpu/mpc85xx/u-boot-spl.lds      | 25 ++---
> >   arch/powerpc/cpu/mpc85xx/u-boot.lds          | 37 +++-----
> >   configs/P1010RDB-PA_36BIT_NAND_defconfig     |  6 +-
> >   configs/P1010RDB-PA_36BIT_SDCARD_defconfig   |  4 +-
> >   configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig |  4 +-
> >   configs/P1010RDB-PA_NAND_defconfig           |  6 +-
> >   configs/P1010RDB-PA_SDCARD_defconfig         |  4 +-
> >   configs/P1010RDB-PA_SPIFLASH_defconfig       |  4 +-
> >   configs/P1010RDB-PB_36BIT_NAND_defconfig     |  6 +-
> >   configs/P1010RDB-PB_36BIT_SDCARD_defconfig   |  4 +-
> >   configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig |  4 +-
> >   configs/P1010RDB-PB_NAND_defconfig           |  6 +-
> >   configs/P1010RDB-PB_SDCARD_defconfig         |  4 +-
> >   configs/P1010RDB-PB_SPIFLASH_defconfig       |  4 +-
> >   configs/P1020RDB-PC_36BIT_NAND_defconfig     |  6 +-
> >   configs/P1020RDB-PC_36BIT_SDCARD_defconfig   |  4 +-
> >   configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig |  4 +-
> >   configs/P1020RDB-PC_NAND_defconfig           |  6 +-
> >   configs/P1020RDB-PC_SDCARD_defconfig         |  4 +-
> >   configs/P1020RDB-PC_SPIFLASH_defconfig       |  4 +-
> >   configs/P1020RDB-PD_NAND_defconfig           |  6 +-
> >   configs/P1020RDB-PD_SDCARD_defconfig         |  4 +-
> >   configs/P1020RDB-PD_SPIFLASH_defconfig       |  4 +-
> >   configs/P2020RDB-PC_36BIT_NAND_defconfig     |  6 +-
> >   configs/P2020RDB-PC_36BIT_SDCARD_defconfig   |  4 +-
> >   configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig |  4 +-
> >   configs/P2020RDB-PC_NAND_defconfig           |  6 +-
> >   configs/P2020RDB-PC_SDCARD_defconfig         |  4 +-
> >   configs/P2020RDB-PC_SPIFLASH_defconfig       |  4 +-
> 
>    Just a quick question here. Do you changes not apply to
> P2041 ?

Hello! I looked at mpc85xx boards which have +0x1000 in its base
addresses and modified them.

P2041RDB_defconfig, P2041RDB_NAND_defconfig, P2041RDB_SDCARD_defconfig
and P2041RDB_SPIFLASH_defconfig do not have +0x1000 in base addresses.

So I'm not sure how are P2041 compiled and what is layout of its address
space. Maybe P2041 needs some other changes? And it is working with
mainline U-Boot?

Do you or somebody else has a chance to test this patch series on some
P2041 board?

>   Best regards
>   Sinan Akman
> 
> >   configs/T1024RDB_NAND_defconfig              |  4 +-
> >   configs/T1024RDB_SDCARD_defconfig            |  2 +-
> >   configs/T1024RDB_SPIFLASH_defconfig          |  2 +-
> >   configs/T1042D4RDB_NAND_defconfig            |  4 +-
> >   configs/T1042D4RDB_SDCARD_defconfig          |  2 +-
> >   configs/T1042D4RDB_SPIFLASH_defconfig        |  2 +-
> >   configs/T2080QDS_NAND_defconfig              |  4 +-
> >   configs/T2080QDS_SDCARD_defconfig            |  2 +-
> >   configs/T2080QDS_SPIFLASH_defconfig          |  2 +-
> >   configs/T2080RDB_NAND_defconfig              |  4 +-
> >   configs/T2080RDB_SDCARD_defconfig            |  2 +-
> >   configs/T2080RDB_SPIFLASH_defconfig          |  2 +-
> >   configs/T2080RDB_revD_NAND_defconfig         |  4 +-
> >   configs/T2080RDB_revD_SDCARD_defconfig       |  2 +-
> >   configs/T2080RDB_revD_SPIFLASH_defconfig     |  2 +-
> >   configs/T4240RDB_SDCARD_defconfig            |  2 +-
> >   configs/qemu-ppce500_defconfig               |  2 +-
> >   include/configs/P1010RDB.h                   | 10 +-
> >   include/configs/T102xRDB.h                   |  3 +
> >   include/configs/T104xRDB.h                   |  3 +
> >   include/configs/T208xQDS.h                   |  3 +
> >   include/configs/T208xRDB.h                   |  3 +
> >   include/configs/p1_p2_rdb_pc.h               | 26 +++---
> >   55 files changed, 127 insertions(+), 322 deletions(-)
> >   delete mode 100644 arch/powerpc/cpu/mpc85xx/u-boot-nand.lds
> >   delete mode 100644 arch/powerpc/cpu/mpc85xx/u-boot-nand_spl.lds
> > 
> 