From: "Pali Rohár" <pali@kernel.org>
To: Tom Rini <trini@konsulko.com>
Cc: Priyanka Jain <priyanka.jain@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2] board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros
Date: Tue, 28 Jun 2022 20:41:44 +0200 [thread overview]
Message-ID: <20220628184144.5rygvzdznwgyb44j@pali> (raw)
In-Reply-To: <20220628183911.GQ1146598@bill-the-cat>
On Tuesday 28 June 2022 14:39:11 Tom Rini wrote:
> On Tue, Jun 28, 2022 at 08:34:47PM +0200, Pali Rohár wrote:
> > On Tuesday 28 June 2022 14:28:52 Tom Rini wrote:
> > > On Tue, Jun 28, 2022 at 08:22:38PM +0200, Pali Rohár wrote:
> > > > On Tuesday 28 June 2022 14:17:42 Tom Rini wrote:
> > > > > On Tue, Jun 28, 2022 at 07:53:55PM +0200, Pali Rohár wrote:
> > > > >
> > > > > > Now when CONFIG_SYS_TEXT_BASE has sane value, use it for calculation of
> > > > > > other SPL offset values: CONFIG_SPL_MAX_SIZE, CONFIG_SYS_MMC_U_BOOT_* and
> > > > > > CONFIG_SYS_SPI_FLASH_U_BOOT_* macros.
> > > > > >
> > > > > > No functional change.
> > > > > >
> > > > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > > > ---
> > > > > > Changes in v2:
> > > > > > * Rebased on top of the U-Boot next branch, commit d61c11b8c894fad517677dc51ee82d1eade39c01
> > > > > > ---
> > > > > > include/configs/p1_p2_rdb_pc.h | 12 ++++++------
> > > > > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > > > > >
> > > > > > diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h
> > > > > > index 56a16502dcc7..7237e3c1a63c 100644
> > > > > > --- a/include/configs/p1_p2_rdb_pc.h
> > > > > > +++ b/include/configs/p1_p2_rdb_pc.h
> > > > > > @@ -78,15 +78,15 @@
> > > > > >
> > > > > > #ifdef CONFIG_SDCARD
> > > > > > #define CONFIG_SYS_MMC_U_BOOT_SIZE (768 << 10)
> > > > > > -#define CONFIG_SYS_MMC_U_BOOT_DST (0x11000000)
> > > > > > -#define CONFIG_SYS_MMC_U_BOOT_START (0x11000000)
> > > > > > -#define CONFIG_SYS_MMC_U_BOOT_OFFS (128 << 10)
> > > > > > +#define CONFIG_SYS_MMC_U_BOOT_DST CONFIG_SYS_TEXT_BASE
> > > > > > +#define CONFIG_SYS_MMC_U_BOOT_START CONFIG_SYS_TEXT_BASE
> > > > > > +#define CONFIG_SYS_MMC_U_BOOT_OFFS CONFIG_SPL_PAD_TO
> > > > > > #define CONFIG_SYS_MPC85XX_NO_RESETVEC
> > > > > > #elif defined(CONFIG_SPIFLASH)
> > > > > > #define CONFIG_SYS_SPI_FLASH_U_BOOT_SIZE (768 << 10)
> > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST (0x11000000)
> > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_START (0x11000000)
> > > > > > -#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS (128 << 10)
> > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_DST CONFIG_SYS_TEXT_BASE
> > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_START CONFIG_SYS_TEXT_BASE
> > > > > > +#define CONFIG_SYS_SPI_FLASH_U_BOOT_OFFS CONFIG_SPL_PAD_TO
> > > > > > #define CONFIG_SYS_MPC85XX_NO_RESETVEC
> > > > > > #elif defined(CONFIG_MTD_RAW_NAND)
> > > > > > #ifdef CONFIG_TPL_BUILD
> > > > >
> > > > > So, this is entirely a PowerPC spl set of CONFIG variables. Can we move
> > > > > them to Kconfig, and use default xxx as you're changing them to above?
> > > > > The other platforms using this look to be doing the same at first
> > > > > glance.
> > > > >
> > > > > --
> > > > > Tom
> > > >
> > > > Not sure how to do it right now. CONFIG_SYS_MMC_U_BOOT_OFFS would need
> > > > to be adjusted by size of boot sector, as is in this patch:
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20220405134032.704-3-pali@kernel.org/
> > > >
> > > > So I just sent patch in current form which simplify definitions of
> > > > CONFIG_SYS_MMC_U_BOOT_* and CONFIG_SYS_SPI_FLASH_U_BOOT_* macros.
> > >
> > > Given the limited places we use CONFIG_SYS_MMC_U_BOOT_OFFS (two spots,
> > > one file), remove it from CONFIG space, make it file local, and
> > > FSL_PREPBL_ESDHC_BOOT_SECTOR will be in Kconfig to start with? I'm
> > > taking a harder look at what CONFIG_SYS_* can be moved to Kconfig, and
> > > what needs to be just something else, and what can be cleaned up /
> > > removed, so I really want to figure out a solution here that migrates
> > > the symbols or removes them from CONFIG namespace.
> > >
> > > --
> > > Tom
> >
> > More than month ago I proposed different solution, prepare codebase to
> > completely drop CONFIG_SYS_MMC_U_BOOT_OFFS option. But nobody reacted to
> > it and now I see on patchwork just "Changes Requested".
> > https://patchwork.ozlabs.org/project/uboot/patch/20220511183332.1362-2-pali@kernel.org/
>
> Er, I see
> https://patchwork.ozlabs.org/project/uboot/patch/20220511183332.1362-1-pali@kernel.org/
> notes it fails to build, so that's probably the changes requested.
>
> --
> Tom
V2 for that build failure already exists and half hour ago I sent
another reminder for v2:
https://lore.kernel.org/u-boot/20220628181436.iwmwvvoithgwp6pu@pali/
but it has nothing with CONFIG_SYS_MMC_U_BOOT_OFFS...
next prev parent reply other threads:[~2022-06-28 18:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:12 [PATCH 0/8] powerpc: mpc85xx: Fix and cleanup mpc85xx code Pali Rohár
2022-04-05 13:12 ` [PATCH 1/8] powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support Pali Rohár
2022-04-08 11:04 ` Pali Rohár
2022-04-05 13:12 ` [PATCH 2/8] powerpc: mpc85xx: Remove duplicate u-boot-nand.lds Pali Rohár
2022-04-05 13:12 ` [PATCH 3/8] powerpc: mpc85xx: Remove u-boot-nand_spl.lds Pali Rohár
2022-04-05 13:12 ` [PATCH 4/8] powerpc: mpc85xx: Remove useless SIZEOF_HEADERS and .interp from ld script Pali Rohár
2022-04-05 13:12 ` [PATCH 5/8] powerpc: mpc85xx: Put bss after image when not including reset vector Pali Rohár
2022-04-05 13:12 ` [PATCH 6/8] powerpc: mpc85xx: Define linker sections in ascending order Pali Rohár
2022-04-05 13:12 ` [PATCH 7/8] powerpc: mpc85xx: Set TEXT_BASE addresses to real base values Pali Rohár
2022-04-25 4:27 ` Priyanka Jain (OSS)
2022-04-25 12:31 ` Pali Rohár
2022-05-11 18:59 ` Pali Rohár
2022-05-18 10:51 ` Pali Rohár
2022-06-04 13:01 ` Pali Rohár
2022-04-25 12:29 ` [PATCH v2] " Pali Rohár
2022-06-16 8:57 ` Peng Fan (OSS)
2022-06-16 9:30 ` Pali Rohár
2022-06-16 12:19 ` [PATCH v3] " Pali Rohár
2022-06-23 11:29 ` Pali Rohár
2022-06-23 12:34 ` Tom Rini
2022-06-28 9:18 ` Pali Rohár
2022-06-28 13:42 ` Tom Rini
2022-06-28 14:52 ` Tom Rini
2022-06-28 17:43 ` Pali Rohár
2022-04-05 13:12 ` [PATCH 8/8] board: freescale: p1_p2_rdb_pc: Simplify SPL offset macros Pali Rohár
2022-06-28 17:53 ` [PATCH v2] " Pali Rohár
2022-06-28 18:17 ` Tom Rini
2022-06-28 18:22 ` Pali Rohár
2022-06-28 18:28 ` Tom Rini
2022-06-28 18:34 ` Pali Rohár
2022-06-28 18:39 ` Tom Rini
2022-06-28 18:41 ` Pali Rohár [this message]
2022-06-28 18:53 ` Tom Rini
2022-06-28 18:58 ` Pali Rohár
2022-06-28 19:08 ` Tom Rini
2022-06-28 19:13 ` Pali Rohár
2022-04-05 17:03 ` [PATCH 0/8] powerpc: mpc85xx: Fix and cleanup mpc85xx code Sinan Akman
2022-04-05 17:17 ` Pali Rohár
2022-04-05 18:10 ` Sinan Akman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628184144.5rygvzdznwgyb44j@pali \
--to=pali@kernel.org \
--cc=peng.fan@oss.nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).