* [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
@ 2022-08-24 15:56 Jorge Ramirez-Ortiz
0 siblings, 0 replies; 5+ messages in thread
From: Jorge Ramirez-Ortiz @ 2022-08-24 15:56 UTC (permalink / raw)
To: jorge, patrice.chotard, hs, patrick.delaunay, oleksandr.suvorov
Cc: uboot-stm32, u-boot
Bits should be set to 0, not 1.
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/i2c/stm32f7_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
index bf2a6c9b4b..3a727e68ac 100644
--- a/drivers/i2c/stm32f7_i2c.c
+++ b/drivers/i2c/stm32f7_i2c.c
@@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
setbits_le32(®s->icr, STM32_I2C_ICR_STOPCF);
/* Clear control register 2 */
- setbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
+ clrbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
}
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
@ 2022-08-15 14:52 Jorge Ramirez-Ortiz
2022-08-24 15:35 ` Patrice CHOTARD
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jorge Ramirez-Ortiz @ 2022-08-15 14:52 UTC (permalink / raw)
To: jorge, hs, patrick.delaunay, patrice.chotard, oleksandr.suvorov
Cc: uboot-stm32, u-boot
Bits should be set to 0, not 1.
Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
---
drivers/i2c/stm32f7_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
index bf2a6c9b4b..3a727e68ac 100644
--- a/drivers/i2c/stm32f7_i2c.c
+++ b/drivers/i2c/stm32f7_i2c.c
@@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
setbits_le32(®s->icr, STM32_I2C_ICR_STOPCF);
/* Clear control register 2 */
- setbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
+ clrbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
}
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
2022-08-15 14:52 Jorge Ramirez-Ortiz
@ 2022-08-24 15:35 ` Patrice CHOTARD
2022-08-30 7:43 ` Patrick DELAUNAY
2022-09-15 15:14 ` Patrick DELAUNAY
2 siblings, 0 replies; 5+ messages in thread
From: Patrice CHOTARD @ 2022-08-24 15:35 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, hs, patrick.delaunay, oleksandr.suvorov
Cc: uboot-stm32, u-boot
Hi Jorge
On 8/15/22 16:52, Jorge Ramirez-Ortiz wrote:
> Bits should be set to 0, not 1.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> drivers/i2c/stm32f7_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
> index bf2a6c9b4b..3a727e68ac 100644
> --- a/drivers/i2c/stm32f7_i2c.c
> +++ b/drivers/i2c/stm32f7_i2c.c
> @@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
> setbits_le32(®s->icr, STM32_I2C_ICR_STOPCF);
>
> /* Clear control register 2 */
> - setbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> + clrbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> }
>
> return ret;
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
2022-08-15 14:52 Jorge Ramirez-Ortiz
2022-08-24 15:35 ` Patrice CHOTARD
@ 2022-08-30 7:43 ` Patrick DELAUNAY
2022-09-15 15:14 ` Patrick DELAUNAY
2 siblings, 0 replies; 5+ messages in thread
From: Patrick DELAUNAY @ 2022-08-30 7:43 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, hs, patrice.chotard, oleksandr.suvorov
Cc: uboot-stm32, u-boot
Hi,
On 8/15/22 16:52, Jorge Ramirez-Ortiz wrote:
> Bits should be set to 0, not 1.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> drivers/i2c/stm32f7_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
> index bf2a6c9b4b..3a727e68ac 100644
> --- a/drivers/i2c/stm32f7_i2c.c
> +++ b/drivers/i2c/stm32f7_i2c.c
> @@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
> setbits_le32(®s->icr, STM32_I2C_ICR_STOPCF);
>
> /* Clear control register 2 */
> - setbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> + clrbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> }
>
> return ret;
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Thanks
Patrick
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register
2022-08-15 14:52 Jorge Ramirez-Ortiz
2022-08-24 15:35 ` Patrice CHOTARD
2022-08-30 7:43 ` Patrick DELAUNAY
@ 2022-09-15 15:14 ` Patrick DELAUNAY
2 siblings, 0 replies; 5+ messages in thread
From: Patrick DELAUNAY @ 2022-09-15 15:14 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, hs, patrice.chotard, oleksandr.suvorov
Cc: uboot-stm32, u-boot, Alain Volmat
Hi,
On 8/15/22 16:52, Jorge Ramirez-Ortiz wrote:
> Bits should be set to 0, not 1.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> drivers/i2c/stm32f7_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
> index bf2a6c9b4b..3a727e68ac 100644
> --- a/drivers/i2c/stm32f7_i2c.c
> +++ b/drivers/i2c/stm32f7_i2c.c
> @@ -413,7 +413,7 @@ static int stm32_i2c_check_end_of_message(struct stm32_i2c_priv *i2c_priv)
> setbits_le32(®s->icr, STM32_I2C_ICR_STOPCF);
>
> /* Clear control register 2 */
> - setbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> + clrbits_le32(®s->cr2, STM32_I2C_CR2_RESET_MASK);
> }
>
> return ret;
Applied to u-boot-stm/master, thanks!
Regards
Patrick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-15 15:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 15:56 [PATCHv2 1/2] i2c: stm32f7: fix clearing the control register Jorge Ramirez-Ortiz
-- strict thread matches above, loose matches on Subject: below --
2022-08-15 14:52 Jorge Ramirez-Ortiz
2022-08-24 15:35 ` Patrice CHOTARD
2022-08-30 7:43 ` Patrick DELAUNAY
2022-09-15 15:14 ` Patrick DELAUNAY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).