* [PATCH 1/1] cmd: missing break in test_write_limit()
@ 2023-04-02 4:51 Heinrich Schuchardt
2023-04-02 18:45 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2023-04-02 4:51 UTC (permalink / raw)
To: Ilias Apalodimas; +Cc: Simon Glass, u-boot, Heinrich Schuchardt
In test_write_limit() an unintended fall-through occurs.
Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
cmd/tpm_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/tpm_test.c b/cmd/tpm_test.c
index b35eae81dc..c4ed8e5901 100644
--- a/cmd/tpm_test.c
+++ b/cmd/tpm_test.c
@@ -471,6 +471,7 @@ static int test_write_limit(struct udevice *dev)
break;
case TPM_MAXNVWRITES:
assert(i >= TPM_MAX_NV_WRITES_NOOWNER);
+ break;
default:
pr_err("\tunexpected error code %d (0x%x)\n",
result, result);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] cmd: missing break in test_write_limit()
2023-04-02 4:51 [PATCH 1/1] cmd: missing break in test_write_limit() Heinrich Schuchardt
@ 2023-04-02 18:45 ` Simon Glass
2023-04-03 5:52 ` Ilias Apalodimas
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2023-04-02 18:45 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Ilias Apalodimas, u-boot
On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> In test_write_limit() an unintended fall-through occurs.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> cmd/tpm_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] cmd: missing break in test_write_limit()
2023-04-02 18:45 ` Simon Glass
@ 2023-04-03 5:52 ` Ilias Apalodimas
0 siblings, 0 replies; 3+ messages in thread
From: Ilias Apalodimas @ 2023-04-03 5:52 UTC (permalink / raw)
To: Simon Glass; +Cc: Heinrich Schuchardt, u-boot
On Sun, 2 Apr 2023 at 21:45, Simon Glass <sjg@chromium.org> wrote:
>
> On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
> >
> > In test_write_limit() an unintended fall-through occurs.
> >
> > Suggested-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> > cmd/tpm_test.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-03 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-02 4:51 [PATCH 1/1] cmd: missing break in test_write_limit() Heinrich Schuchardt
2023-04-02 18:45 ` Simon Glass
2023-04-03 5:52 ` Ilias Apalodimas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).