[PATCH 1/1] cmd: missing break in test_write_limit()

[PATCH 1/1] cmd: missing break in test_write_limit()

[Heinrich Schuchardt]

In test_write_limit() an unintended fall-through occurs.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 cmd/tpm_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/tpm_test.c b/cmd/tpm_test.c
index b35eae81dc..c4ed8e5901 100644
--- a/cmd/tpm_test.c
+++ b/cmd/tpm_test.c
@@ -471,6 +471,7 @@ static int test_write_limit(struct udevice *dev)
 			break;
 		case TPM_MAXNVWRITES:
 			assert(i >= TPM_MAX_NV_WRITES_NOOWNER);
+			break;
 		default:
 			pr_err("\tunexpected error code %d (0x%x)\n",
 			      result, result);
-- 
2.39.2

Re: [PATCH 1/1] cmd: missing break in test_write_limit()

[Simon Glass]

On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> In test_write_limit() an unintended fall-through occurs.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  cmd/tpm_test.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH 1/1] cmd: missing break in test_write_limit()

[Ilias Apalodimas]

On Sun, 2 Apr 2023 at 21:45, Simon Glass <sjg@chromium.org> wrote:
>
> On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
> >
> > In test_write_limit() an unintended fall-through occurs.
> >
> > Suggested-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> >  cmd/tpm_test.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>