From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] cmd: convert fallthrough comment.
Date: Fri, 7 Apr 2023 10:50:11 -0400 [thread overview]
Message-ID: <20230407145011.GO1134230@bill-the-cat> (raw)
In-Reply-To: <20230401071411.110815-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Sat, Apr 01, 2023 at 09:14:11AM +0200, Heinrich Schuchardt wrote:
> gcc does not understand /* FALL TROUGH */ and emits a warning:
>
> cmd/date.c: In function ‘do_date’:
> cmd/date.c:62:20: warning:
> this statement may fall through [-Wimplicit-fallthrough=]
> 62 | if (strcmp(argv[1],"reset") == 0) {
> | ^
> cmd/date.c:102:9: note: here
> 102 | case 1: /* get date & time */
> | ^~~~
>
> Use the fallthrough macro instead.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-04-07 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 7:14 [PATCH 1/1] cmd: convert fallthrough comment Heinrich Schuchardt
2023-04-02 2:26 ` Simon Glass
2023-04-07 14:50 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407145011.GO1134230@bill-the-cat \
--to=trini@konsulko.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).