u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Tom Rini <trini@konsulko.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] cmd: convert fallthrough comment.
Date: Sun, 2 Apr 2023 14:26:28 +1200	[thread overview]
Message-ID: <CAPnjgZ39Vic0pb7JH84vfgu=UqkBDSUrq1YsVNK62o+X2QtFgg@mail.gmail.com> (raw)
In-Reply-To: <20230401071411.110815-1-heinrich.schuchardt@canonical.com>

On Sat, 1 Apr 2023 at 20:14, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> gcc does not understand /* FALL TROUGH */ and emits a warning:
>
>     cmd/date.c: In function ‘do_date’:
>     cmd/date.c:62:20: warning:
>     this statement may fall through [-Wimplicit-fallthrough=]
>        62 |                 if (strcmp(argv[1],"reset") == 0) {
>           |                    ^
>     cmd/date.c:102:9: note: here
>       102 |         case 1:                 /* get date & time */
>           |         ^~~~
>
> Use the fallthrough macro instead.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  cmd/date.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2023-04-02  2:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  7:14 [PATCH 1/1] cmd: convert fallthrough comment Heinrich Schuchardt
2023-04-02  2:26 ` Simon Glass [this message]
2023-04-07 14:50 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ39Vic0pb7JH84vfgu=UqkBDSUrq1YsVNK62o+X2QtFgg@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).