From: Sean Anderson <seanga2@gmail.com>
To: Angus Ainslie <angus@akkea.ca>,
u-boot@lists.denx.de, Marek Vasut <marex@denx.de>
Cc: lukma@denx.de, sbabic@denx.de, festevam@gmail.com,
kernel@puri.sm, uboot-imx@nxp.com, peng.fan@nxp.com
Subject: Re: [PATCH v4 4/4] clk: imx8m: remove code duplication
Date: Sun, 20 Mar 2022 19:58:52 -0400 [thread overview]
Message-ID: <4b714cbf-a7b8-032b-0792-f9bf1c99be8a@gmail.com> (raw)
In-Reply-To: <20220315130820.1054186-5-angus@akkea.ca>
Hi Angus,
On 3/15/22 9:08 AM, Angus Ainslie wrote:
> All of the imx8m[nmpq] use the same clk_ops functions so move them
> to a common file.
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/clk/imx/Makefile | 8 +--
> drivers/clk/imx/clk-imx8m.c | 108 +++++++++++++++++++++++++++++++++++
> drivers/clk/imx/clk-imx8m.h | 12 ++++
> drivers/clk/imx/clk-imx8mm.c | 89 +----------------------------
> drivers/clk/imx/clk-imx8mn.c | 89 +----------------------------
> drivers/clk/imx/clk-imx8mp.c | 91 +----------------------------
> drivers/clk/imx/clk-imx8mq.c | 91 +----------------------------
> 7 files changed, 132 insertions(+), 356 deletions(-)
> create mode 100644 drivers/clk/imx/clk-imx8m.c
> create mode 100644 drivers/clk/imx/clk-imx8m.h
Looks like this is accomplishing the same thing as [1], which also covers
at91 and mpfs. Great minds think alike :)
Would it be possible for you to rebase your series on mine?
--Sean
[1] https://patchwork.ozlabs.org/project/uboot/patch/20220320203446.740178-2-seanga2@gmail.com/
prev parent reply other threads:[~2022-03-20 23:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 13:08 [PATCH v4 0/4] Add a clock driver for the imx8mq Angus Ainslie
2022-03-15 13:08 ` [PATCH v4 1/4] dt-bindings: imx8mq-clock: add mainline definitions Angus Ainslie
2022-03-15 13:08 ` [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq Angus Ainslie
2022-03-15 15:12 ` Heiko Thiery
2022-03-15 15:35 ` Heiko Thiery
2022-03-15 15:46 ` Angus Ainslie
2022-03-15 16:13 ` Angus Ainslie
2022-03-16 7:14 ` Heiko Thiery
2022-03-16 12:26 ` Heiko Thiery
2022-03-16 12:35 ` Angus Ainslie
2022-03-16 14:02 ` Heiko Thiery
2022-03-16 14:15 ` Angus Ainslie
2022-03-16 14:21 ` Heiko Thiery
2022-03-16 15:55 ` Heiko Thiery
2022-03-16 16:00 ` Angus Ainslie
2022-03-16 16:20 ` Michael Walle
2022-03-21 1:38 ` Peng Fan (OSS)
2022-03-15 19:01 ` Marek Vasut
2022-03-16 7:02 ` Heiko Thiery
2022-03-21 1:32 ` Peng Fan (OSS)
2022-03-20 23:57 ` Sean Anderson
2022-03-24 8:28 ` Heiko Thiery
2022-03-24 12:06 ` Angus Ainslie
2022-03-15 13:08 ` [PATCH v4 3/4] clk: imx8m: reduce rate table duplication Angus Ainslie
2022-03-15 13:08 ` [PATCH v4 4/4] clk: imx8m: remove code duplication Angus Ainslie
2022-03-20 23:58 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b714cbf-a7b8-032b-0792-f9bf1c99be8a@gmail.com \
--to=seanga2@gmail.com \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=kernel@puri.sm \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).