Re: [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq

From: Heiko Thiery <heiko.thiery@gmail.com>
To: Angus Ainslie <angus.ainslie@puri.sm>
Cc: Angus Ainslie <angus@akkea.ca>,
	u-boot@lists.denx.de, Marek Vasut <marex@denx.de>,
	lukma@denx.de,  seanga2@gmail.com, sbabic@denx.de,
	festevam@gmail.com, kernel@puri.sm,  uboot-imx@nxp.com,
	peng.fan@nxp.com
Subject: Re: [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq
Date: Wed, 16 Mar 2022 08:14:02 +0100	[thread overview]
Message-ID: <CAEyMn7Z+T2NjPCON8xBedg+DmkMDZPjS+MJkQ_3W5m5HcTVdLA@mail.gmail.com> (raw)
In-Reply-To: <d36708f5-a6a1-686b-f01b-fca0c8e4734a@puri.sm>

Hi Angus,

Am Di., 15. März 2022 um 16:46 Uhr schrieb Angus Ainslie
<angus.ainslie@puri.sm>:
>
> Hi Heiko,
>
> On 2022-03-15 08:35, Heiko Thiery wrote:
>
> Hi Angus and all,
>
>
>
>
> Am Di., 15. März 2022 um 14:09 Uhr schrieb Angus Ainslie <angus@akkea.ca>:
>>
>> This is a DM clock driver based off the imx8mm u-boot driver and the linux
>> kernel driver.
>>
>> All of the PLLs and clocks are initialized so the subsystems below are
>> functional and tested.
>>
>> 1) USB host and peripheral
>> 2) ECSPI
>> 3) UART
>> 4) I2C all busses
>> 5) USDHC for eMMC support
>> 6) USB storage
>> 7) GPIO
>> 8) DRAM
>>
>>
> Snip
>
>
> when adding this patch and enabling CLK_IMX8MQ I see the following on my board .. Any idea what I missed here?
>
> --- >8 ---
> U-Boot SPL 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100)
> Trying to boot from SD card
>
>
> U-Boot 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100)
>
> CPU:   Freescale i.MX8MQ rev2.1 at 800 MHz
> Reset cause: POR
> Model: Kontron pITX-imx8m
> DRAM:  alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> alloc space exhausted
> 4 GiB
>
> My guess is that there was static code that was setting up the DRAM pll that isn't get executed now that there's a DM clock driver.
>
> I'd try enabling DEBUG in the clk-uclass and clk-composite drivers.
>
> Also look at what DRAM initialization code is not being run now. Our board doesn't have an DRAM specific initialization so there could be a bug in the DRAM setup.

The problem was the MALLOC_F_LEN value. Increasing that the "alloc
space exhausted" is gone.

But with the enabled DM_SERIAL the problem of "No serial driver found"
is still there and the board reboots. You said you have DM_SERIAL
enabled and it works?

[snip]

-- 
Heiko