Re: [PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq

[Heiko Thiery <heiko.thiery@gmail.com>]

Hi Angus,

Am Di., 15. März 2022 um 14:09 Uhr schrieb Angus Ainslie <angus@akkea.ca>:

> This is a DM clock driver based off the imx8mm u-boot driver and the linux
> kernel driver.
>
> All of the PLLs and clocks are initialized so the subsystems below are
> functional and tested.
>
> 1) USB host and peripheral
> 2) ECSPI
> 3) UART
> 4) I2C all busses
> 5) USDHC for eMMC support
> 6) USB storage
> 7) GPIO
> 8) DRAM
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
>  drivers/clk/imx/Kconfig      |  16 +
>  drivers/clk/imx/Makefile     |   2 +
>  drivers/clk/imx/clk-imx8mq.c | 575 +++++++++++++++++++++++++++++++++++
>  3 files changed, 593 insertions(+)
>  create mode 100644 drivers/clk/imx/clk-imx8mq.c
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index cdd348020b0..06d8c1a5dd3 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -71,6 +71,22 @@ config CLK_IMX8MP
>         help
>           This enables support clock driver for i.MX8MP platforms.
>
> +config SPL_CLK_IMX8MQ
> +       bool "SPL clock support for i.MX8MQ"
> +       depends on ARCH_IMX8M && SPL
> +       select SPL_CLK
> +       select SPL_CLK_CCF
>

you should select SPL_CLK_COMPOSITE_CCF ...


> +       help
> +         This enables SPL DM/DTS support for clock driver in i.MX8MQ
> +
> +config CLK_IMX8MQ
> +       bool "Clock support for i.MX8MQ"
> +       depends on ARCH_IMX8M
> +       select CLK
> +       select CLK_CCF
>

.. and select CLK_COMPOSITE_CCF here.


> +       help
> +         This enables support clock driver for i.MX8MQ platforms.
> +
>  config SPL_CLK_IMXRT1020
>         bool "SPL clock support for i.MXRT1020"
>         depends on ARCH_IMXRT && SPL
>
> [SNIP]

-- 
Heiko