u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Andre Przywara <andre.przywara@arm.com>,
	 Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH 3/4] phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling
Date: Fri, 15 Jul 2022 14:46:19 +0530	[thread overview]
Message-ID: <CAMty3ZA9hY72eqAG0nRJLPg-3LSd5LUWcsW9RsFMRKe95MubTw@mail.gmail.com> (raw)
In-Reply-To: <20220715040922.451-4-samuel@sholland.org>

On Fri, Jul 15, 2022 at 9:39 AM Samuel Holland <samuel@sholland.org> wrote:
>
> From: Andre Przywara <andre.przywara@arm.com>
>
> As Icenowy pointed out, newer manuals (starting with H6) actually
> document the register block at offset 0x800 as "HCI controller and PHY
> interface", also describe the bits in our "PMU_UNK1" register.
> Let's put proper names to those "unknown" variables and symbols.
>
> While we are at it, generalise the existing code by allowing a bitmap
> of bits to clear and set, to cover newer SoCs: The A100 and H616 use a
> different bit for the SIDDQ control.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---

Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>

  reply	other threads:[~2022-07-15  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  4:09 [PATCH 0/4] phy: sun4i-usb: Allwinner D1 Support Samuel Holland
2022-07-15  4:09 ` [PATCH 1/4] sunxi: Move INITIAL_USB_SCAN_DELAY to driver Kconfig Samuel Holland
2022-07-15  9:15   ` Jagan Teki
2022-07-15  4:09 ` [PATCH 2/4] phy: sun4i-usb: Drop use of arch-specific headers Samuel Holland
2022-07-15  9:15   ` Jagan Teki
2022-07-15  4:09 ` [PATCH 3/4] phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling Samuel Holland
2022-07-15  9:16   ` Jagan Teki [this message]
2022-07-15  4:09 ` [PATCH 4/4] phy: sun4i-usb: Add D1 variant Samuel Holland
2022-07-15  9:16   ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMty3ZA9hY72eqAG0nRJLPg-3LSd5LUWcsW9RsFMRKe95MubTw@mail.gmail.com \
    --to=jagan@amarulasolutions.com \
    --cc=andre.przywara@arm.com \
    --cc=joe.hershberger@ni.com \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).