* [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
@ 2021-09-30 10:53 tekkamanv
2021-10-02 14:15 ` Bin Meng
2021-10-08 12:58 ` Jagan Teki
0 siblings, 2 replies; 6+ messages in thread
From: tekkamanv @ 2021-09-30 10:53 UTC (permalink / raw)
To: u-boot, bmeng.cn, jagan, vigneshr
Cc: tekkamanv, tekkamanv, tekkamanninja, yanhong.wang
From: "yanhong.wang" <yanhong.wang@starfivetech.com>
Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
---
drivers/mtd/spi/spi-nor-ids.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e..35fa347c44 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+ {
+ INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
#endif
#ifdef CONFIG_SPI_FLASH_ISSI /* ISSI */
/* ISSI */
--
2.25.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
2021-09-30 10:53 [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID tekkamanv
@ 2021-10-02 14:15 ` Bin Meng
2021-10-08 12:58 ` Jagan Teki
1 sibling, 0 replies; 6+ messages in thread
From: Bin Meng @ 2021-10-02 14:15 UTC (permalink / raw)
To: tekkamanv
Cc: U-Boot Mailing List, Jagan Teki, Vignesh R, tekkamanv,
tekkamanninja, yanhong.wang
On Thu, Sep 30, 2021 at 6:55 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>
Please add a brief commit message for this, like providing a datasheet
for reference:
https://www.gigadevice.com/datasheet/gd25lq256d/
> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
I believe the name should be spelled as "Yanhong Wang"
> ---
> drivers/mtd/spi/spi-nor-ids.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..35fa347c44 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> + {
> + INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + },
> #endif
> #ifdef CONFIG_SPI_FLASH_ISSI /* ISSI */
> /* ISSI */
Otherwise LGTM:
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
2021-09-30 10:53 [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID tekkamanv
2021-10-02 14:15 ` Bin Meng
@ 2021-10-08 12:58 ` Jagan Teki
2021-10-08 15:13 ` Bin Meng
1 sibling, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2021-10-08 12:58 UTC (permalink / raw)
To: tekkamanv
Cc: U-Boot-Denx, Bin Meng, Vignesh R, tekkamanv, tekkamanninja, yanhong.wang
On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>
> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> ---
Applied to u-boot-spi/master
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
2021-10-08 12:58 ` Jagan Teki
@ 2021-10-08 15:13 ` Bin Meng
2021-10-09 8:51 ` Jagan Teki
0 siblings, 1 reply; 6+ messages in thread
From: Bin Meng @ 2021-10-08 15:13 UTC (permalink / raw)
To: Jagan Teki
Cc: tekkamanv, U-Boot-Denx, Vignesh R, tekkamanv, tekkamanninja,
yanhong.wang
HI Jagan,
On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
> >
> > From: "yanhong.wang" <yanhong.wang@starfivetech.com>
> >
> > Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> > ---
>
> Applied to u-boot-spi/master
Did you address my comments when applying?
Regards,
Bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
2021-10-08 15:13 ` Bin Meng
@ 2021-10-09 8:51 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2021-10-09 8:51 UTC (permalink / raw)
To: Bin Meng
Cc: tekkamanv, U-Boot-Denx, Vignesh R, tekkamanv, tekkamanninja,
yanhong.wang
Hi Bin,
On Fri, Oct 8, 2021 at 8:43 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> HI Jagan,
>
> On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
> > >
> > > From: "yanhong.wang" <yanhong.wang@starfivetech.com>
> > >
> > > Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> > > ---
> >
> > Applied to u-boot-spi/master
>
> Did you address my comments when applying?
Yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID
@ 2021-09-30 11:53 tekkamanv
0 siblings, 0 replies; 6+ messages in thread
From: tekkamanv @ 2021-09-30 11:53 UTC (permalink / raw)
To: u-boot, bmeng.cn, rick, ycliang
Cc: tekkamanv, tekkamanv, tekkamanninja, yanhong.wang
From: "yanhong.wang" <yanhong.wang@starfivetech.com>
Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
---
drivers/mtd/spi/spi-nor-ids.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e..35fa347c44 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+ {
+ INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
#endif
#ifdef CONFIG_SPI_FLASH_ISSI /* ISSI */
/* ISSI */
--
2.25.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-09 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 10:53 [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID tekkamanv
2021-10-02 14:15 ` Bin Meng
2021-10-08 12:58 ` Jagan Teki
2021-10-08 15:13 ` Bin Meng
2021-10-09 8:51 ` Jagan Teki
2021-09-30 11:53 tekkamanv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).