u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Vyacheslav <adeep@lexina.in>
To: u-boot-amlogic@groups.io, narmstrong@baylibre.com
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/3] ARM: amlogic: add JetHub D1/H1 device support
Date: Mon, 20 Sep 2021 10:06:15 +0300	[thread overview]
Message-ID: <a6c09812-c63a-d0dd-37e7-d59ccf4e174f@lexina.in> (raw)
In-Reply-To: <4ef4798b-33a3-76f9-f4a7-83ec7e4b893a@baylibre.com>

20.09.2021 09:43, Neil Armstrong wrote:
> Hi,
> 
> On 19/09/2021 17:52, Vyacheslav Bocharov wrote:
>> Add support for new home automation devices.
> 
> While applying I had a few warnings:
> 
>> +	if (!env_get("serial")) {
>> +		len = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial,
> 
> ERROR: trailing whitespace
> #777: FILE: board/amlogic/jethub-j80/jethub-j80.c:48:
> +^I^Ilen = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial, $
> 
> CHECK: Alignment should match open parenthesis
> #778: FILE: board/amlogic/jethub-j80/jethub-j80.c:49:
> +		len = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial,
> +			EFUSE_SN_SIZE);
> 
> CHECK: Alignment should match open parenthesis
> #785: FILE: board/amlogic/jethub-j80/jethub-j80.c:56:
> +		len = meson_sm_read_efuse(EFUSE_USID_OFFSET, usid,
> +			EFUSE_USID_SIZE);

I'll double-check everything and resend a new version of the patches.

> 
> This file isn't part of any MAINTAINERS file, either add it to the s400 one or the j80 one.

I'll add it to jethub-j80/MAINTAINERS.

Thanks!



  reply	other threads:[~2021-09-20  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 15:52 [PATCH v2 0/3] ARM: meson: add support for JetHub D1/H1 Vyacheslav Bocharov
2021-09-19 15:52 ` [PATCH v2 1/3] ARM: amlogic: add JetHub common config header Vyacheslav Bocharov
2021-09-19 15:52 ` [PATCH v2 2/3] ARM: amlogic: add JetHub D1/H1 device support Vyacheslav Bocharov
2021-09-20  6:43   ` Neil Armstrong
2021-09-20  7:06     ` Vyacheslav [this message]
2021-09-19 15:52 ` [PATCH v2 3/3] ARM: amlogic: add JetHub D1/H1 docs Vyacheslav Bocharov
2021-09-20  6:46   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c09812-c63a-d0dd-37e7-d59ccf4e174f@lexina.in \
    --to=adeep@lexina.in \
    --cc=narmstrong@baylibre.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).