* [PATCH] net: gem: Check rate before setting it up
@ 2022-08-26 8:30 Michal Simek
2022-08-31 8:14 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2022-08-26 8:30 UTC (permalink / raw)
To: u-boot, git; +Cc: Joe Hershberger, Ramon Fried
On QEMU setting rate for fixed clock is failing. That's why check a rate
first if the rate is the same there is no need to ask for the change.
Signed-off-by: Michal Simek <michal.simek@amd.com>
---
drivers/net/zynq_gem.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index 4e8dd4badd6b..61a6c83e335d 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -500,10 +500,13 @@ static int zynq_gem_init(struct udevice *dev)
}
#endif
- ret = clk_set_rate(&priv->tx_clk, clk_rate);
- if (IS_ERR_VALUE(ret)) {
- dev_err(dev, "failed to set tx clock rate\n");
- return ret;
+ ret = clk_get_rate(&priv->tx_clk);
+ if (ret != clk_rate) {
+ ret = clk_set_rate(&priv->tx_clk, clk_rate);
+ if (IS_ERR_VALUE(ret)) {
+ dev_err(dev, "failed to set tx clock rate %ld\n", clk_rate);
+ return ret;
+ }
}
ret = clk_enable(&priv->tx_clk);
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: gem: Check rate before setting it up
2022-08-26 8:30 [PATCH] net: gem: Check rate before setting it up Michal Simek
@ 2022-08-31 8:14 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2022-08-31 8:14 UTC (permalink / raw)
To: u-boot, git; +Cc: Joe Hershberger, Ramon Fried
On 8/26/22 10:30, Michal Simek wrote:
> On QEMU setting rate for fixed clock is failing. That's why check a rate
> first if the rate is the same there is no need to ask for the change.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> drivers/net/zynq_gem.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index 4e8dd4badd6b..61a6c83e335d 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -500,10 +500,13 @@ static int zynq_gem_init(struct udevice *dev)
> }
> #endif
>
> - ret = clk_set_rate(&priv->tx_clk, clk_rate);
> - if (IS_ERR_VALUE(ret)) {
> - dev_err(dev, "failed to set tx clock rate\n");
> - return ret;
> + ret = clk_get_rate(&priv->tx_clk);
> + if (ret != clk_rate) {
> + ret = clk_set_rate(&priv->tx_clk, clk_rate);
> + if (IS_ERR_VALUE(ret)) {
> + dev_err(dev, "failed to set tx clock rate %ld\n", clk_rate);
> + return ret;
> + }
> }
>
> ret = clk_enable(&priv->tx_clk);
Applied.
M
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-31 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 8:30 [PATCH] net: gem: Check rate before setting it up Michal Simek
2022-08-31 8:14 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).