bashcompletiondir should not be set or tested when --disable-bash-completion is given

* bashcompletiondir should not be set or tested when --disable-bash-completion is given
@ 2022-06-14  8:52 Rolf Eike Beer
  2022-06-14 13:58 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Rolf Eike Beer @ 2022-06-14  8:52 UTC (permalink / raw)
  To: util-linux

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

I tried building some util-linux libraries in a minimal chroot (no pkg-config). 
At the end it boils down to

./configure --disable-bash-completion <other stuff>

The result of this was:

checking for ECONF... no
./configure: line 37542: --exists: command not found
checking for a Python interpreter with version >= 2... none
[...]

        Bash completions:          ${datarootdir}/bash-completion/completions
        Systemd support:           no
[...]
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/sbin'
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/share/bash-completion/
completions'
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/share/man/man1'

The problem with the "--exists" is this line (of course at a totally different 
line number in configure):

  if `$PKG_CONFIG --exists bash-completion`; then :

The PKG_CONFIG variable is empty and in contrast to most other places, the 
other notable exceptions being the checks for tinfow, tinfo, and 
libcryptsetup, the variable is not checked for being empty before usage. And 
at the end this should probably somehow depend on enable_bash_completion=yes 
to avoid creating an empty directory as well.

Regards,

Eike
-- 
Besuchen Sie uns auf der Embedded World 2022 in Nürnberg!
-> 21.-23.06.2022 - Halle 4, Stand 336

Rolf Eike Beer, emlix GmbH, https://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread