fdisk Ctrl+C

fdisk Ctrl+C

[Jonny Grant]

Hello!

A few questions, ideas

1. Could Ctrl+C be added to get out of changing a partition type?

2 Could the partition code check that it is hex. At the moment if I type 
'q' I get partition type 0.

3.
For partition type 0, which is called "Empty" probably this message 
should say "Empty" and not 'unknown' ?

=======
Changed type of partition 'W95 FAT32 (LBA)' to 'unknown'.
=======

Would a patch be accepted for this?


NB. See log below for more info.

Regards, Jonny




$ fdisk --version
fdisk from util-linux 2.31.1


# fdisk /dev/sdb

Welcome to fdisk (util-linux 2.31.1).
Changes will remain in memory only, until you decide to write them.
Be careful before using the write command.


Command (m for help): p
Disk /dev/sdb: 114.6 GiB, 123010547712 bytes, 240254976 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x00000000

Device     Boot Start       End   Sectors   Size Id Type
/dev/sdb1          32 240254975 240254944 114.6G  c W95 FAT32 (LBA)

Command (m for help): t
Selected partition 1
Hex code (type L to list all codes): ^CHex code (type L to list all codes):


Hex code (type L to list all codes): q
Type 0 means free space to many systems. Having partitions of type 0 is 
probably unwise.

Changed type of partition 'W95 FAT32 (LBA)' to 'unknown'.

Command (m for help):

Re: fdisk Ctrl+C

[Karel Zak]

On Wed, Jan 09, 2019 at 06:01:18PM +0000, Jonny Grant wrote:
> 1. Could Ctrl+C be added to get out of changing a partition type?

Implemented.

> 2 Could the partition code check that it is hex. At the moment if I type 'q'
> I get partition type 0.

Fixed.

> 3.
> For partition type 0, which is called "Empty" probably this message should
> say "Empty" and not 'unknown' ?

Works for me now.

Thanks for your report.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: fdisk Ctrl+C

[Jonny Grant]

On 10/01/2019 11:22, Karel Zak wrote:
> On Wed, Jan 09, 2019 at 06:01:18PM +0000, Jonny Grant wrote:
>> 1. Could Ctrl+C be added to get out of changing a partition type?
> 
> Implemented.
> 
>> 2 Could the partition code check that it is hex. At the moment if I type 'q'
>> I get partition type 0.
> 
> Fixed.
> 
>> 3.
>> For partition type 0, which is called "Empty" probably this message should
>> say "Empty" and not 'unknown' ?
> 
> Works for me now.
> 
> Thanks for your report.
> 
>      Karel

Great work!
Looking forward to my next dist-upgrade
Jonny