From: Aleksa Sarai <cyphar@cyphar.com>
To: Bruno Wolff III <bruno@wolff.to>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402
Date: Thu, 14 Mar 2019 18:10:24 +1100 [thread overview]
Message-ID: <20190314071024.i2iz6l4rc3jnlzaq@yavin> (raw)
In-Reply-To: <20190314053402.GA10226@wolff.to>
[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]
On 2019-03-14, Bruno Wolff III <bruno@wolff.to> wrote:
> Sorry about the duplicates. I git confused trying to use git email-send.
For future reference, you want to send a patch series. The way I do it
is I first generate all of the patches:
% git format-patch <base-commit>
Which will then generate NNNN-patch_description.patch files. Modify
these to your heart's content (you can also generate a cover page with
--cover-letter to git format-patch, or a version number with -v).
Then, you can send them all *as one series* by doing:
% git send-email --no-chain-reply-to --no-format-patch \
--to=<to-list> --cc=<cc-list> \
*.patch
(This makes them all one thread so it's far more obvious which patches
go together -- since it looks like you were sending multiple patches
separately, which causes confusion for folks reading them.)
You're also missing a Signed-off-by:, but I'm not sure if WireGuard
contributions require those (you can add them with `git commit -s`).
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-03-20 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:21 [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402 Bruno Wolff III
2019-03-14 5:34 ` Bruno Wolff III
2019-03-14 7:10 ` Aleksa Sarai [this message]
2019-03-14 12:41 ` Bruno Wolff III
2019-03-14 13:24 ` Luis Ressel
-- strict thread matches above, loose matches on Subject: below --
2019-03-14 18:25 Bruno Wolff III
2019-03-14 18:52 ` Jason A. Donenfeld
2019-03-14 5:32 Bruno Wolff III
2019-03-14 5:24 Bruno Wolff III
2019-03-14 5:14 Bruno Wolff III
2019-03-14 17:05 ` Bruno Wolff III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314071024.i2iz6l4rc3jnlzaq@yavin \
--to=cyphar@cyphar.com \
--cc=bruno@wolff.to \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).