From: Luis Ressel <aranea@aixah.de>
To: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402
Date: Thu, 14 Mar 2019 14:24:09 +0100 [thread overview]
Message-ID: <20190314132409.ubkqxeyebirsx75n@deneb.skynet.aixah.de> (raw)
In-Reply-To: <20190314124134.GB20943@wolff.to>
On Thu, Mar 14, 2019 at 07:41:34AM -0500, Bruno Wolff III wrote:
> On Thu, Mar 14, 2019 at 18:10:24 +1100,
> Aleksa Sarai <cyphar@cyphar.com> wrote:
>
> > You're also missing a Signed-off-by:, but I'm not sure if WireGuard
> > contributions require those (you can add them with `git commit -s`).
Yes, it is indeed neccessary to sign off all contributions to wireguard.
> Can you set up your config to do that automatically or are you supposed to
> do that manually for each commit to make sure you really mean it?
Yes and no. There's no way to make git append the s-o-b line to all
commit messages, but if you enable the format.signOff config option,
it will at least add the line when you invoke git format-patch or git
send-email.
Cheers,
Luis
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-03-14 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:21 [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402 Bruno Wolff III
2019-03-14 5:34 ` Bruno Wolff III
2019-03-14 7:10 ` Aleksa Sarai
2019-03-14 12:41 ` Bruno Wolff III
2019-03-14 13:24 ` Luis Ressel [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-14 18:25 Bruno Wolff III
2019-03-14 18:52 ` Jason A. Donenfeld
2019-03-14 5:32 Bruno Wolff III
2019-03-14 5:24 Bruno Wolff III
2019-03-14 5:14 Bruno Wolff III
2019-03-14 17:05 ` Bruno Wolff III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314132409.ubkqxeyebirsx75n@deneb.skynet.aixah.de \
--to=aranea@aixah.de \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).