From: Bruno Wolff III <bruno@wolff.to>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402
Date: Thu, 14 Mar 2019 07:41:34 -0500 [thread overview]
Message-ID: <20190314124134.GB20943@wolff.to> (raw)
In-Reply-To: <20190314071024.i2iz6l4rc3jnlzaq@yavin>
On Thu, Mar 14, 2019 at 18:10:24 +1100,
Aleksa Sarai <cyphar@cyphar.com> wrote:
>
>For future reference, you want to send a patch series. The way I do it
>is I first generate all of the patches:
Thanks. That isn't what I was trying to do here, but something I might
do in the future. Here the two patches were separate, nit part of the
series. I got confused in that I thought the mail wasn't getting set
and tried a few different varients of the --smtp-server= option, most
of which actually worked.
>You're also missing a Signed-off-by:, but I'm not sure if WireGuard
>contributions require those (you can add them with `git commit -s`).
Can you set up your config to do that automatically or are you supposed
to do that manually for each commit to make sure you really mean it?
In this case, one patch is trivial and the other needs to be reworked,
so I doubt it matters.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-03-14 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:21 [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402 Bruno Wolff III
2019-03-14 5:34 ` Bruno Wolff III
2019-03-14 7:10 ` Aleksa Sarai
2019-03-14 12:41 ` Bruno Wolff III [this message]
2019-03-14 13:24 ` Luis Ressel
-- strict thread matches above, loose matches on Subject: below --
2019-03-14 18:25 Bruno Wolff III
2019-03-14 18:52 ` Jason A. Donenfeld
2019-03-14 5:32 Bruno Wolff III
2019-03-14 5:24 Bruno Wolff III
2019-03-14 5:14 Bruno Wolff III
2019-03-14 17:05 ` Bruno Wolff III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314124134.GB20943@wolff.to \
--to=bruno@wolff.to \
--cc=cyphar@cyphar.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).