Ideas from Jane Street's code review

Ideas from Jane Street's code review

[Barret Rhoden]

Hi -

Jane Street did some interesting things with their code review and 
workflow, such as handling diffs-of-diffs and tracking what needs to be 
reviewed.

Their ideas might be orthogonal to the whole "workflow that works for 
email / web / your-tool-here" discussion, but some of the underlying 
principles may inspire a good overall design:

Tech talk:
https://blog.janestreet.com/jane-street-tech-talk-how-jane-street-does-code-review/

Links to their blogs:
https://github.com/janestreet/iron

Barret

Re: Ideas from Jane Street's code review

[Dmitry Vyukov]

On Thu, Sep 26, 2019 at 5:06 PM Barret Rhoden <brho@google.com> wrote:
>
> Hi -
>
> Jane Street did some interesting things with their code review and
> workflow, such as handling diffs-of-diffs and tracking what needs to be
> reviewed.
>
> Their ideas might be orthogonal to the whole "workflow that works for
> email / web / your-tool-here" discussion, but some of the underlying
> principles may inspire a good overall design:
>
> Tech talk:
> https://blog.janestreet.com/jane-street-tech-talk-how-jane-street-does-code-review/
>
> Links to their blogs:
> https://github.com/janestreet/iron


Interesting idea of editing, saving and committing comments along with
the code into review branches.
Added it to the list for completeness:
https://github.com/dvyukov/kit/blob/master/doc/references.md#iron
Thanks, Barret.