From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/4] libnvdimm: Cross-arch compatible namespace alignment
Date: Fri, 14 Feb 2020 16:03:47 -0500 [thread overview]
Message-ID: <x49blq0dgp8.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <158155489850.3343782.2687127373754434980.stgit@dwillia2-desk3.amr.corp.intel.com> (Dan Williams's message of "Wed, 12 Feb 2020 16:48:18 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
> ---
>
> Explicit review requests, but any other feedback is of course
> appreciated:
>
> Patch1 needs an ack from ppc arch maintainers, and I'd like a tested-by
> from Aneesh that this still works to solve the ppc issue. Jeff, does
> this look good to you?
OK, I've reviewed everything. Testing looks good with the change I
mentioned (memremap_compat_align returning PAGE_SIZE). I made sure a
4k-aligned namespace created under an unpatched kernel would be
accessible under a patched kernel. I also made sure that manually
setting align would allow for creating of poorly aligned namespaces, and
that those namespaces were then accessible on the unpatched kernel.
Thanks, Dan!
-Jeff
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, Oliver O'Halloran <oohall@gmail.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/4] libnvdimm: Cross-arch compatible namespace alignment
Date: Fri, 14 Feb 2020 16:03:47 -0500 [thread overview]
Message-ID: <x49blq0dgp8.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <158155489850.3343782.2687127373754434980.stgit@dwillia2-desk3.amr.corp.intel.com> (Dan Williams's message of "Wed, 12 Feb 2020 16:48:18 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
> ---
>
> Explicit review requests, but any other feedback is of course
> appreciated:
>
> Patch1 needs an ack from ppc arch maintainers, and I'd like a tested-by
> from Aneesh that this still works to solve the ppc issue. Jeff, does
> this look good to you?
OK, I've reviewed everything. Testing looks good with the change I
mentioned (memremap_compat_align returning PAGE_SIZE). I made sure a
4k-aligned namespace created under an unpatched kernel would be
accessible under a patched kernel. I also made sure that manually
setting align would allow for creating of poorly aligned namespaces, and
that those namespaces were then accessible on the unpatched kernel.
Thanks, Dan!
-Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Moyer <jmoyer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org,
Vishal Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org,
Oliver O'Halloran <oohall@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/4] libnvdimm: Cross-arch compatible namespace alignment
Date: Fri, 14 Feb 2020 16:03:47 -0500 [thread overview]
Message-ID: <x49blq0dgp8.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <158155489850.3343782.2687127373754434980.stgit@dwillia2-desk3.amr.corp.intel.com> (Dan Williams's message of "Wed, 12 Feb 2020 16:48:18 -0800")
Dan Williams <dan.j.williams@intel.com> writes:
> ---
>
> Explicit review requests, but any other feedback is of course
> appreciated:
>
> Patch1 needs an ack from ppc arch maintainers, and I'd like a tested-by
> from Aneesh that this still works to solve the ppc issue. Jeff, does
> this look good to you?
OK, I've reviewed everything. Testing looks good with the change I
mentioned (memremap_compat_align returning PAGE_SIZE). I made sure a
4k-aligned namespace created under an unpatched kernel would be
accessible under a patched kernel. I also made sure that manually
setting align would allow for creating of poorly aligned namespaces, and
that those namespaces were then accessible on the unpatched kernel.
Thanks, Dan!
-Jeff
next prev parent reply other threads:[~2020-02-14 21:03 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 0:48 [PATCH v2 0/4] libnvdimm: Cross-arch compatible namespace alignment Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` [PATCH v2 1/4] mm/memremap_pages: Introduce memremap_compat_align() Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 16:57 ` Jeff Moyer
2020-02-13 16:57 ` Jeff Moyer
2020-02-13 16:57 ` Jeff Moyer
2020-02-13 18:26 ` Dan Williams
2020-02-13 18:26 ` Dan Williams
2020-02-13 18:26 ` Dan Williams
2020-02-14 3:26 ` Aneesh Kumar K.V
2020-02-14 3:26 ` Aneesh Kumar K.V
2020-02-14 3:26 ` Aneesh Kumar K.V
2020-02-14 20:59 ` Jeff Moyer
2020-02-14 20:59 ` Jeff Moyer
2020-02-14 20:59 ` Jeff Moyer
2020-02-14 23:05 ` Dan Williams
2020-02-14 23:05 ` Dan Williams
2020-02-14 23:05 ` Dan Williams
2020-02-13 0:48 ` [PATCH v2 2/4] libnvdimm/namespace: Enforce memremap_compat_align() Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 19:16 ` Jeff Moyer
2020-02-13 19:16 ` Jeff Moyer
2020-02-13 19:16 ` Jeff Moyer
2020-02-13 21:55 ` Jeff Moyer
2020-02-13 21:55 ` Jeff Moyer
2020-02-13 21:55 ` Jeff Moyer
2020-02-13 22:43 ` Dan Williams
2020-02-13 22:43 ` Dan Williams
2020-02-13 22:43 ` Dan Williams
2020-02-14 16:44 ` Jeff Moyer
2020-02-14 16:44 ` Jeff Moyer
2020-02-14 16:44 ` Jeff Moyer
2020-02-14 16:55 ` Aneesh Kumar K.V
2020-02-14 16:55 ` Aneesh Kumar K.V
2020-02-14 16:55 ` Aneesh Kumar K.V
2020-02-13 0:48 ` [PATCH v2 3/4] libnvdimm/region: Introduce NDD_LABELING Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 19:12 ` Jeff Moyer
2020-02-13 19:12 ` Jeff Moyer
2020-02-13 19:12 ` Jeff Moyer
2020-02-13 0:48 ` [PATCH v2 4/4] libnvdimm/region: Introduce an 'align' attribute Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-13 0:48 ` Dan Williams
2020-02-14 20:19 ` Jeff Moyer
2020-02-14 20:19 ` Jeff Moyer
2020-02-14 20:19 ` Jeff Moyer
2020-02-14 21:03 ` Jeff Moyer [this message]
2020-02-14 21:03 ` [PATCH v2 0/4] libnvdimm: Cross-arch compatible namespace alignment Jeff Moyer
2020-02-14 21:03 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49blq0dgp8.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.