From: Paul Durrant <xadimgnik@gmail.com>
To: "'Andrew Cooper'" <andrew.cooper3@citrix.com>,
"'Xen-devel'" <xen-devel@lists.xenproject.org>
Cc: 'Ian Jackson' <Ian.Jackson@citrix.com>,
'Daniel De Graaf' <dgdegra@tycho.nsa.gov>, 'Wei Liu' <wl@xen.org>
Subject: RE: [PATCH] tools/configure: drop BASH configure variable
Date: Mon, 29 Jun 2020 08:41:05 +0100 [thread overview]
Message-ID: <000201d64de8$a5938bf0$f0baa3d0$@xen.org> (raw)
In-Reply-To: <20200626170038.27650-1-andrew.cooper3@citrix.com>
> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Sent: 26 June 2020 18:01
> To: Xen-devel <xen-devel@lists.xenproject.org>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Wei Liu
> <wl@xen.org>; Daniel De Graaf <dgdegra@tycho.nsa.gov>; Paul Durrant <paul@xen.org>
> Subject: [PATCH] tools/configure: drop BASH configure variable
>
> This is a weird variable to have in the first place. The only user of it is
> XSM's CONFIG_SHELL, which opencodes a fallback to sh, and the only two scripts
> run with this are shebang sh anyway, so don't need bash in the first place.
>
> Make the mkflask.sh and mkaccess_vector.sh scripts executable, drop the
> CONFIG_SHELL, and drop the $BASH variable to prevent further use.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Ian Jackson <Ian.Jackson@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> CC: Paul Durrant <paul@xen.org>
>
> ./autogen.sh needs rerunning on commit.
>
> RFC for 4.14. This is a cleanup to the build system.
>
> There is a separate check for [BASH] in the configure script, which is
> checking the requirement for the Linux hotplug scripts. Really, that is a
> runtime requirement not a build time requirement, and it is rude to require
> bash in a build environment on this basis. IMO, that check wants dropping as
> well.
That sounds quite reasonable.
Release-acked-by: Paul Durrant <paul@xen.org>
> ---
> config/Tools.mk.in | 1 -
> tools/configure.ac | 1 -
> xen/xsm/flask/Makefile | 8 ++------
> xen/xsm/flask/policy/mkaccess_vector.sh | 0
> xen/xsm/flask/policy/mkflask.sh | 0
> 5 files changed, 2 insertions(+), 8 deletions(-)
> mode change 100644 => 100755 xen/xsm/flask/policy/mkaccess_vector.sh
> mode change 100644 => 100755 xen/xsm/flask/policy/mkflask.sh
>
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 23df47af8d..48bd9ab731 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -12,7 +12,6 @@ PYTHON := @PYTHON@
> PYTHON_PATH := @PYTHONPATH@
> PY_NOOPT_CFLAGS := @PY_NOOPT_CFLAGS@
> PERL := @PERL@
> -BASH := @BASH@
> XGETTTEXT := @XGETTEXT@
> AS86 := @AS86@
> LD86 := @LD86@
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 9d126b7a14..6614a4f130 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -297,7 +297,6 @@ AC_ARG_VAR([PYTHON], [Path to the Python parser])
> AC_ARG_VAR([PERL], [Path to Perl parser])
> AC_ARG_VAR([BISON], [Path to Bison parser generator])
> AC_ARG_VAR([FLEX], [Path to Flex lexical analyser generator])
> -AC_ARG_VAR([BASH], [Path to bash shell])
> AC_ARG_VAR([XGETTEXT], [Path to xgetttext tool])
> AC_ARG_VAR([AS86], [Path to as86 tool])
> AC_ARG_VAR([LD86], [Path to ld86 tool])
> diff --git a/xen/xsm/flask/Makefile b/xen/xsm/flask/Makefile
> index 07f36d075d..ba8f31a02c 100644
> --- a/xen/xsm/flask/Makefile
> +++ b/xen/xsm/flask/Makefile
> @@ -8,10 +8,6 @@ CFLAGS-y += -I./include
>
> AWK = awk
>
> -CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
> - else if [ -x /bin/bash ]; then echo /bin/bash; \
> - else echo sh; fi ; fi)
> -
> FLASK_H_DEPEND = policy/security_classes policy/initial_sids
> AV_H_DEPEND = policy/access_vectors
>
> @@ -24,14 +20,14 @@ extra-y += $(ALL_H_FILES)
>
> mkflask := policy/mkflask.sh
> quiet_cmd_mkflask = MKFLASK $@
> -cmd_mkflask = $(CONFIG_SHELL) $(mkflask) $(AWK) include $(FLASK_H_DEPEND)
> +cmd_mkflask = $(mkflask) $(AWK) include $(FLASK_H_DEPEND)
>
> $(subst include/,%/,$(FLASK_H_FILES)): $(FLASK_H_DEPEND) $(mkflask) FORCE
> $(call if_changed,mkflask)
>
> mkaccess := policy/mkaccess_vector.sh
> quiet_cmd_mkaccess = MKACCESS VECTOR $@
> -cmd_mkaccess = $(CONFIG_SHELL) $(mkaccess) $(AWK) $(AV_H_DEPEND)
> +cmd_mkaccess = $(mkaccess) $(AWK) $(AV_H_DEPEND)
>
> $(subst include/,%/,$(AV_H_FILES)): $(AV_H_DEPEND) $(mkaccess) FORCE
> $(call if_changed,mkaccess)
> diff --git a/xen/xsm/flask/policy/mkaccess_vector.sh b/xen/xsm/flask/policy/mkaccess_vector.sh
> old mode 100644
> new mode 100755
> diff --git a/xen/xsm/flask/policy/mkflask.sh b/xen/xsm/flask/policy/mkflask.sh
> old mode 100644
> new mode 100755
> --
> 2.11.0
next prev parent reply other threads:[~2020-06-29 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 11:32 [PATCH v2] tools/configure: drop BASH configure variable Andrew Cooper
2020-06-26 17:00 ` [PATCH] " Andrew Cooper
2020-06-29 7:41 ` Paul Durrant [this message]
2020-06-29 8:41 ` Jan Beulich
2020-06-29 12:05 ` Ian Jackson
2020-06-29 14:38 ` Jan Beulich
2020-07-31 13:02 ` [PATCH] tools/configure: drop BASH configure variable [and 1 more messages] Ian Jackson
2020-07-31 13:30 ` Jan Beulich
2020-07-31 13:46 ` Andrew Cooper
2020-07-31 13:47 ` Jan Beulich
2020-06-29 13:34 ` [PATCH] tools/configure: drop BASH configure variable Ian Jackson
2020-06-29 13:51 ` Andrew Cooper
2020-06-29 14:00 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201d64de8$a5938bf0$f0baa3d0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=Ian.Jackson@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).