From: Jan Beulich <jbeulich@suse.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Paul Durrant <paul@xen.org>, Wei Liu <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] tools/configure: drop BASH configure variable
Date: Mon, 29 Jun 2020 16:38:32 +0200 [thread overview]
Message-ID: <2c202733-cbff-74e0-30c6-4cba227e7969@suse.com> (raw)
In-Reply-To: <24313.55588.61431.336617@mariner.uk.xensource.com>
On 29.06.2020 14:05, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"):
>> On 26.06.2020 19:00, Andrew Cooper wrote:
>>> diff --git a/xen/xsm/flask/policy/mkaccess_vector.sh b/xen/xsm/flask/policy/mkaccess_vector.sh
>>> old mode 100644
>>> new mode 100755
>>> diff --git a/xen/xsm/flask/policy/mkflask.sh b/xen/xsm/flask/policy/mkflask.sh
>>> old mode 100644
>>> new mode 100755
>>
>> ... this may or may not take effect on the file system the sources
>> are stored on.
>
> In what circumstances might this not take effect ?
When the file system is incapable of recording execute permissions?
It has been a common workaround for this in various projects that
I've worked with to use $(SHELL) to account for that, so the actual
permissions from the fs don't matter. (There may be mount options
to make everything executable on such file systems, but people may
be hesitant to use them.)
Jan
> IME all changes to files are properly replicated by git. Tarball
> distributions replicate the permissions of course.
>
> The only difficulty would be if this change were to be carried as a
> patch somewhere, by a downstream, but that seems unlikely, and can be
> avoided by that downstream not taking this patch.
>
> Ian.
>
next prev parent reply other threads:[~2020-06-29 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 11:32 [PATCH v2] tools/configure: drop BASH configure variable Andrew Cooper
2020-06-26 17:00 ` [PATCH] " Andrew Cooper
2020-06-29 7:41 ` Paul Durrant
2020-06-29 8:41 ` Jan Beulich
2020-06-29 12:05 ` Ian Jackson
2020-06-29 14:38 ` Jan Beulich [this message]
2020-07-31 13:02 ` [PATCH] tools/configure: drop BASH configure variable [and 1 more messages] Ian Jackson
2020-07-31 13:30 ` Jan Beulich
2020-07-31 13:46 ` Andrew Cooper
2020-07-31 13:47 ` Jan Beulich
2020-06-29 13:34 ` [PATCH] tools/configure: drop BASH configure variable Ian Jackson
2020-06-29 13:51 ` Andrew Cooper
2020-06-29 14:00 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c202733-cbff-74e0-30c6-4cba227e7969@suse.com \
--to=jbeulich@suse.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.jackson@citrix.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).