From: Ian Jackson <ian.jackson@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>, Wei Liu <wl@xen.org>,
Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] tools/configure: drop BASH configure variable [and 1 more messages]
Date: Fri, 31 Jul 2020 14:02:32 +0100 [thread overview]
Message-ID: <24356.5736.297234.341867@mariner.uk.xensource.com> (raw)
In-Reply-To: <2c202733-cbff-74e0-30c6-4cba227e7969@suse.com>, <20200722113258.3673-1-andrew.cooper3@citrix.com>
Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"):
> On 29.06.2020 14:05, Ian Jackson wrote:
> > Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"):
> >> On 26.06.2020 19:00, Andrew Cooper wrote:
> >> ... this may or may not take effect on the file system the sources
> >> are stored on.
> >
> > In what circumstances might this not take effect ?
>
> When the file system is incapable of recording execute permissions?
> It has been a common workaround for this in various projects that
> I've worked with to use $(SHELL) to account for that, so the actual
> permissions from the fs don't matter. (There may be mount options
> to make everything executable on such file systems, but people may
> be hesitant to use them.)
I don't think we support building from sources which have been
unpacked onto such filesystems. Other projects which might actually
need to build on Windows or something do do this $(SHELL) thing or an
equivalent, but I don't think that's us.
But obviously that opinion of mine is not a blocker for Andy's patch
since Andy is going in the right direction, regardless.
Andrew Cooper writes ("[PATCH v2] tools/configure: drop BASH configure variable"):
> This is a weird variable to have in the first place. The only user of it is
> XSM's CONFIG_SHELL, which opencodes a fallback to sh, and the only two scripts
> run with this are shebang sh anyway, so don't need bash in the first place.
>
> Make the mkflask.sh and mkaccess_vector.sh scripts executable, drop the
> CONFIG_SHELL, and drop the $BASH variable to prevent further use.
In response to this commit message, I wrote:
> > Andrew Cooper writes ("[PATCH] tools/configure: drop BASH configure variable"):
> > Thanks for this cleanup. I agree with the basic idea.
> >
> > However, did you run these scripts with dash, or review them, to check
> > for bashisms ?
And you replied:
> Yes, to all of the above.
>
> They are both very thin wrappers (doing some argument shuffling) around
> large AWK scripts.
Can you please put this information in the commit message where it
belongs ? As a rule we should know in future what we were thinking
when a change was made, and as I say "are shebang sh anyway, so don't
need bash in the first place" is weak evidence.
With that change,
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks,
Ian.
next prev parent reply other threads:[~2020-07-31 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 11:32 [PATCH v2] tools/configure: drop BASH configure variable Andrew Cooper
2020-06-26 17:00 ` [PATCH] " Andrew Cooper
2020-06-29 7:41 ` Paul Durrant
2020-06-29 8:41 ` Jan Beulich
2020-06-29 12:05 ` Ian Jackson
2020-06-29 14:38 ` Jan Beulich
2020-07-31 13:02 ` Ian Jackson [this message]
2020-07-31 13:30 ` [PATCH] tools/configure: drop BASH configure variable [and 1 more messages] Jan Beulich
2020-07-31 13:46 ` Andrew Cooper
2020-07-31 13:47 ` Jan Beulich
2020-06-29 13:34 ` [PATCH] tools/configure: drop BASH configure variable Ian Jackson
2020-06-29 13:51 ` Andrew Cooper
2020-06-29 14:00 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24356.5736.297234.341867@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).