* [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
@ 2019-09-25 15:27 Jan Beulich
2019-09-26 15:23 ` Jürgen Groß
2019-10-08 9:32 ` [Xen-devel] Ping: " Jan Beulich
0 siblings, 2 replies; 6+ messages in thread
From: Jan Beulich @ 2019-09-25 15:27 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Andrew Cooper, Wei Liu, Roger Pau Monné
There's nothing to restore here if there's no FPU in the first place.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
To be considered for 4.13 since RSTR_FP_ERR_PTRS support was introduced
just recently.
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -168,8 +168,9 @@ def crunch_numbers(state):
deps = {
# FPU is taken to mean support for the x87 regisers as well as the
# instructions. MMX is documented to alias the %MM registers over the
- # x87 %ST registers in hardware.
- FPU: [MMX],
+ # x87 %ST registers in hardware. Correct restoring of error pointers
+ # of course makes no sense without there being anything to restore.
+ FPU: [MMX, RSTR_FP_ERR_PTRS],
# The PSE36 feature indicates that reserved bits in a PSE superpage
# may be used as extra physical address bits.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
2019-09-25 15:27 [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU Jan Beulich
@ 2019-09-26 15:23 ` Jürgen Groß
2019-12-09 13:06 ` Jan Beulich
2019-10-08 9:32 ` [Xen-devel] Ping: " Jan Beulich
1 sibling, 1 reply; 6+ messages in thread
From: Jürgen Groß @ 2019-09-26 15:23 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
On 25.09.19 17:27, Jan Beulich wrote:
> There's nothing to restore here if there's no FPU in the first place.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
2019-09-26 15:23 ` Jürgen Groß
@ 2019-12-09 13:06 ` Jan Beulich
2019-12-09 14:00 ` Jürgen Groß
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2019-12-09 13:06 UTC (permalink / raw)
To: Jürgen Groß
Cc: xen-devel, Roger Pau Monné, Wei Liu, Andrew Cooper
On 26.09.2019 17:23, Jürgen Groß wrote:
> On 25.09.19 17:27, Jan Beulich wrote:
>> There's nothing to restore here if there's no FPU in the first place.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Release-acked-by: Juergen Gross <jgross@suse.com>
While I've committed the change to the unstable branch, making use of
this R-a-b now without asking would seem abusive to me. I'd expect
you don't want the 4.13 branch disturbed more than really helpful,
and hence I expect you'd rather not see this go in there now. Please
let me know if you view this differently.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
2019-12-09 13:06 ` Jan Beulich
@ 2019-12-09 14:00 ` Jürgen Groß
0 siblings, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2019-12-09 14:00 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Andrew Cooper, Wei Liu, Roger Pau Monné
On 09.12.19 14:06, Jan Beulich wrote:
> On 26.09.2019 17:23, Jürgen Groß wrote:
>> On 25.09.19 17:27, Jan Beulich wrote:
>>> There's nothing to restore here if there's no FPU in the first place.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Release-acked-by: Juergen Gross <jgross@suse.com>
>
> While I've committed the change to the unstable branch, making use of
> this R-a-b now without asking would seem abusive to me. I'd expect
> you don't want the 4.13 branch disturbed more than really helpful,
> and hence I expect you'd rather not see this go in there now. Please
> let me know if you view this differently.
I appreciate that a lot. Please don't commit this to 4.13 now. :-)
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Xen-devel] Ping: [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
2019-09-25 15:27 [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU Jan Beulich
2019-09-26 15:23 ` Jürgen Groß
@ 2019-10-08 9:32 ` Jan Beulich
2019-12-06 18:48 ` Andrew Cooper
1 sibling, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2019-10-08 9:32 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Juergen Gross, xen-devel, Wei Liu, Roger Pau Monné
On 25.09.2019 17:27, Jan Beulich wrote:
> There's nothing to restore here if there's no FPU in the first place.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> To be considered for 4.13 since RSTR_FP_ERR_PTRS support was introduced
> just recently.
And already release-acked by Jürgen.
Jan
> --- a/xen/tools/gen-cpuid.py
> +++ b/xen/tools/gen-cpuid.py
> @@ -168,8 +168,9 @@ def crunch_numbers(state):
> deps = {
> # FPU is taken to mean support for the x87 regisers as well as the
> # instructions. MMX is documented to alias the %MM registers over the
> - # x87 %ST registers in hardware.
> - FPU: [MMX],
> + # x87 %ST registers in hardware. Correct restoring of error pointers
> + # of course makes no sense without there being anything to restore.
> + FPU: [MMX, RSTR_FP_ERR_PTRS],
>
> # The PSE36 feature indicates that reserved bits in a PSE superpage
> # may be used as extra physical address bits.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] Ping: [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU
2019-10-08 9:32 ` [Xen-devel] Ping: " Jan Beulich
@ 2019-12-06 18:48 ` Andrew Cooper
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2019-12-06 18:48 UTC (permalink / raw)
To: Jan Beulich; +Cc: Juergen Gross, xen-devel, Wei Liu, Roger Pau Monné
On 08/10/2019 10:32, Jan Beulich wrote:
> On 25.09.2019 17:27, Jan Beulich wrote:
>> There's nothing to restore here if there's no FPU in the first place.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> To be considered for 4.13 since RSTR_FP_ERR_PTRS support was introduced
>> just recently.
> And already release-acked by Jürgen.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-09 14:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 15:27 [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU Jan Beulich
2019-09-26 15:23 ` Jürgen Groß
2019-12-09 13:06 ` Jan Beulich
2019-12-09 14:00 ` Jürgen Groß
2019-10-08 9:32 ` [Xen-devel] Ping: " Jan Beulich
2019-12-06 18:48 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).