From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] build: centralize / unify asm-offsets generation
Date: Thu, 1 Apr 2021 16:05:20 +0100 [thread overview]
Message-ID: <089e3ff0-5633-02b4-baac-328ea8618469@xen.org> (raw)
In-Reply-To: <fa340caa-4ee1-a302-fbf1-1df400493d6b@suse.com>
Hi Jan,
On 01/04/2021 09:33, Jan Beulich wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -341,7 +341,7 @@ _clean: delete-unfresh-files
> find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
> -o -name "*.gcno" -o -name ".*.cmd" \) -exec rm -f {} \;
> rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map *~ core
> - rm -f include/asm-*/asm-offsets.h
> + rm -f asm-offsets.s include/asm-*/asm-offsets.h
> rm -f .banner
>
> .PHONY: _distclean
> @@ -362,7 +362,7 @@ $(TARGET): delete-unfresh-files
> done; \
> true
> $(MAKE) -f $(BASEDIR)/Rules.mk -C include
> - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) asm-offsets.s
> + $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
> $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h
> $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@
>
> @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi
> @sed -rf tools/process-banner.sed < .banner >> $@.new
> @mv -f $@.new $@
>
> -include/asm-$(TARGET_ARCH)/asm-offsets.h: arch/$(TARGET_ARCH)/asm-offsets.s
> +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c
> + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $<
> + $(call move-if-changed,$@.new,$@)
> +
> +include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s
> @(set -e; \
> echo "/*"; \
> echo " * DO NOT MODIFY."; \
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -131,8 +131,8 @@ $(TARGET)-syms: prelink.o xen.lds
> >$(@D)/$(@F).map
> rm -f $(@D)/.$(@F).[0-9]*
>
> -asm-offsets.s: $(TARGET_SUBARCH)/asm-offsets.c
> - $(CC) $(filter-out -flto,$(c_flags)) -S -o $@ $<
> +.PHONY: include
> +include:
From a generic PoV, this target is meant to generate arch-specific
include. Is that correct?
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-04-01 15:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 8:33 [PATCH] build: centralize / unify asm-offsets generation Jan Beulich
2021-04-01 15:05 ` Julien Grall [this message]
2021-04-01 15:29 ` Jan Beulich
2021-04-15 9:50 ` Ping: " Jan Beulich
2021-04-20 15:29 ` Roger Pau Monné
2021-04-20 15:47 ` Jan Beulich
2021-04-20 16:20 ` Roger Pau Monné
2021-04-21 14:09 ` Jan Beulich
2021-04-27 9:05 ` Roger Pau Monné
2021-04-27 12:30 ` Jan Beulich
2021-04-27 13:31 ` Roger Pau Monné
2021-04-27 13:40 ` Jan Beulich
2021-04-27 14:13 ` Roger Pau Monné
2021-04-29 9:18 ` Ping: " Jan Beulich
2021-05-10 17:43 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089e3ff0-5633-02b4-baac-328ea8618469@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).