[PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest

[PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest

[Ian Campbell]

Like the umount this is useful when running the test/job repeatedly in
development, since it allows the LV to be destroyed.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 ts-debian-install | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ts-debian-install b/ts-debian-install
index 0dfe40c..7d02ec4 100755
--- a/ts-debian-install
+++ b/ts-debian-install
@@ -42,6 +42,7 @@ sub prep () {
                        $swap_mb + $disk_mb + 2,
                        40);
     target_cmd_root($ho, "umount $gho->{Lvdev} ||:");
+    target_cmd_root($ho, "service nbd-server stop ||:");
 }
 
 sub ginstall () {
-- 
2.1.4

Re: [PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest

[Ian Jackson]

Ian Campbell writes ("[PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest"):
> Like the umount this is useful when running the test/job repeatedly in
> development, since it allows the LV to be destroyed.

This will cause trouble if the host is shared.  This is not a bug
right now because the nbd server only runs in a job which is already
pretty heavy-handed.

But, also, it seems rather action-at-a-distance.  ts-debian-install
has no other knowledge of nbd.

Ian.

Re: [PATCH OSSTEST] ts-debian-install: Stop nbd-server before creating the guest

[Ian Campbell]

On Fri, 2015-07-24 at 14:39 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] ts-debian-install: Stop nbd-server 
> before creating the guest"):
> > Like the umount this is useful when running the test/job repeatedly in
> > development, since it allows the LV to be destroyed.
> 
> This will cause trouble if the host is shared.  This is not a bug
> right now because the nbd server only runs in a job which is already
> pretty heavy-handed.
> 
> But, also, it seems rather action-at-a-distance.  ts-debian-install
> has no other knowledge of nbd.

Yes, I wasn't sure where else it could go though.

TBH, this was annoying while I was writing the new migration testcase, but
now I'm done I can live without this.

Ian.