From: Joao Martins <joao.m.martins@oracle.com>
To: xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Joao Martins <joao.m.martins@oracle.com>,
Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 2/6] x86/time: refactor init_platform_time()
Date: Tue, 29 Mar 2016 14:44:07 +0100 [thread overview]
Message-ID: <1459259051-4943-3-git-send-email-joao.m.martins@oracle.com> (raw)
In-Reply-To: <1459259051-4943-1-git-send-email-joao.m.martins@oracle.com>
And accomodate platform time source initialization in
try_platform_time(). This is a preparatory patch for deferring
TSC clocksource initialization to the stage where all CPUS are
up (verify_tsc_reliability init call).
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
---
Cc: Keir Fraser <keir@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
New in v2.
---
xen/arch/x86/time.c | 41 ++++++++++++++++++++++++++---------------
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c
index 687e39b..ed4ed24 100644
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -533,6 +533,30 @@ static void resume_platform_timer(void)
plt_stamp = plt_src.read_counter();
}
+static int __init try_platform_timer(struct platform_timesource *pts)
+{
+ int rc = -1;
+
+ rc = pts->init(pts);
+ if ( rc <= 0 )
+ return rc;
+
+ plt_mask = (u64)~0ull >> (64 - pts->counter_bits);
+
+ set_time_scale(&plt_scale, pts->frequency);
+
+ plt_overflow_period = scale_delta(
+ 1ull << (pts->counter_bits - 1), &plt_scale);
+ init_timer(&plt_overflow_timer, plt_overflow, NULL, 0);
+ plt_src = *pts;
+ plt_overflow(NULL);
+
+ platform_timer_stamp = plt_stamp64;
+ stime_platform_stamp = NOW();
+
+ return rc;
+}
+
static void __init init_platform_timer(void)
{
static struct platform_timesource * __initdata plt_timers[] = {
@@ -549,7 +573,7 @@ static void __init init_platform_timer(void)
pts = plt_timers[i];
if ( !strcmp(opt_clocksource, pts->id) )
{
- rc = pts->init(pts);
+ rc = try_platform_timer(pts);
break;
}
}
@@ -565,26 +589,13 @@ static void __init init_platform_timer(void)
for ( i = 0; i < ARRAY_SIZE(plt_timers); i++ )
{
pts = plt_timers[i];
- if ( (rc = pts->init(pts)) > 0 )
+ if ( (rc = try_platform_timer(pts)) > 0 )
break;
}
}
BUG_ON(rc <= 0);
- plt_mask = (u64)~0ull >> (64 - pts->counter_bits);
-
- set_time_scale(&plt_scale, pts->frequency);
-
- plt_overflow_period = scale_delta(
- 1ull << (pts->counter_bits-1), &plt_scale);
- init_timer(&plt_overflow_timer, plt_overflow, NULL, 0);
- plt_src = *pts;
- plt_overflow(NULL);
-
- platform_timer_stamp = plt_stamp64;
- stime_platform_stamp = NOW();
-
printk("Platform timer is %s %s\n",
freq_string(pts->frequency), pts->name);
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-29 13:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 13:44 [PATCH v2 0/6] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2016-03-29 13:44 ` [PATCH v2 1/6] public/xen.h: add flags field to vcpu_time_info Joao Martins
2016-03-30 15:49 ` Ian Jackson
2016-03-30 16:33 ` Joao Martins
2016-03-31 7:09 ` Jan Beulich
2016-03-31 7:13 ` Jan Beulich
2016-03-31 11:04 ` Joao Martins
2016-04-05 10:16 ` Jan Beulich
2016-04-05 10:59 ` Joao Martins
2016-03-29 13:44 ` Joao Martins [this message]
2016-04-01 16:10 ` [PATCH v2 2/6] x86/time: refactor init_platform_time() Konrad Rzeszutek Wilk
2016-04-01 18:26 ` Joao Martins
2016-04-05 10:09 ` Jan Beulich
2016-04-05 10:55 ` Joao Martins
2016-04-05 11:16 ` Jan Beulich
2016-03-29 13:44 ` [PATCH v2 3/6] x86/time: implement tsc as clocksource Joao Martins
2016-03-29 17:39 ` Konrad Rzeszutek Wilk
2016-03-29 17:52 ` Joao Martins
2016-04-01 16:43 ` Konrad Rzeszutek Wilk
2016-04-01 18:38 ` Joao Martins
2016-04-01 18:45 ` Konrad Rzeszutek Wilk
2016-04-03 18:47 ` Joao Martins
2016-04-05 10:43 ` Jan Beulich
2016-04-05 14:56 ` Joao Martins
2016-04-05 15:12 ` Jan Beulich
2016-04-05 17:07 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 4/6] x86/time: streamline platform time init on plt_init() Joao Martins
2016-04-05 11:46 ` Jan Beulich
2016-04-05 15:12 ` Joao Martins
2016-04-05 15:22 ` Jan Beulich
2016-04-05 17:17 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 5/6] x86/time: refactor read_platform_stime() Joao Martins
2016-04-01 18:32 ` Konrad Rzeszutek Wilk
2016-04-05 11:52 ` Jan Beulich
2016-04-05 15:22 ` Joao Martins
2016-04-05 15:26 ` Jan Beulich
2016-04-05 17:08 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2016-04-05 12:22 ` Jan Beulich
2016-04-05 21:34 ` Joao Martins
2016-04-07 15:58 ` Jan Beulich
2016-04-07 21:17 ` Joao Martins
2016-04-07 21:32 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459259051-4943-3-git-send-email-joao.m.martins@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).