From: Joao Martins <joao.m.martins@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 4/6] x86/time: streamline platform time init on plt_init()
Date: Tue, 5 Apr 2016 16:12:52 +0100 [thread overview]
Message-ID: <5703D5F4.6040901@oracle.com> (raw)
In-Reply-To: <5703C1C202000078000E325F@prv-mh.provo.novell.com>
On 04/05/2016 12:46 PM, Jan Beulich wrote:
>>>> On 29.03.16 at 15:44, <joao.m.martins@oracle.com> wrote:
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -434,6 +434,7 @@ uint64_t ns_to_acpi_pm_tick(uint64_t ns)
>> /************************************************************
>> * PLATFORM TIMER 4: TSC
>> */
>> +static bool_t clocksource_is_tsc;
>
> __read_mostly, but see below.
>
>> @@ -516,17 +519,31 @@ static s_time_t __read_platform_stime(u64 platform_time)
>> return (stime_platform_stamp + scale_delta(diff, &plt_scale));
>> }
>>
>> +static void __plt_init(void)
>> +{
>> + u64 count;
>> +
>> + ASSERT(spin_is_locked(&platform_timer_lock));
>> + count = plt_src.read_counter();
>> + plt_stamp64 += (count - plt_stamp) & plt_mask;
>> + plt_stamp = count;
>> +}
>
> Note that this has nothing to do with "init" - it updates the two time
> stamps, as is being made clear by ...
>
>> static void plt_overflow(void *unused)
>> {
>> int i;
>> - u64 count;
>> s_time_t now, plt_now, plt_wrap;
>>
>> spin_lock_irq(&platform_timer_lock);
>>
>> - count = plt_src.read_counter();
>> - plt_stamp64 += (count - plt_stamp) & plt_mask;
>> - plt_stamp = count;
>> + __plt_init();
>
> ... this use.
>
Would you prefer changing the name to e.g "set_plt_stamp" ?
>> @@ -621,11 +638,22 @@ static int __init try_platform_timer(struct platform_timesource *pts)
>>
>> set_time_scale(&plt_scale, pts->frequency);
>>
>> - plt_overflow_period = scale_delta(
>> - 1ull << (pts->counter_bits - 1), &plt_scale);
>> - init_timer(&plt_overflow_timer, plt_overflow, NULL, 0);
>> plt_src = *pts;
>> - plt_overflow(NULL);
>> +
>> + if ( clocksource_is_tsc )
>
> Why not simply "if ( pts == plt_tsc )", eliminating the need for the
> variable?
Yeah, good point. I will fix that.
>
>> + {
>> + plt_init();
>> + }
>> + else
>> + {
>> + plt_overflow_period = scale_delta(
>> + 1ull << (pts->counter_bits - 1), &plt_scale);
>> + init_timer(&plt_overflow_timer, plt_overflow, NULL, 0);
>> + plt_overflow(NULL);
>> +
>> + printk("Platform timer overflow period is %lu secs\n",
>> + plt_overflow_period/SECONDS(1));
>
> If we want this logged at all, then please at most as XENLOG_INFO.
OK.
> Plus - is seconds granularity fine grained enough for all sources, i.e.
> wouldn't there for typical HPET just be a single digit, not a lot of
> precision that is?
Could be, my HPET was around 2 minutes overflow period, but PIT was a single
digit as you mention. I will change that to MILLISECS(1000) for higher precision
- or I can remove it entirely if you prefer not logging this info.
> And finally: Blanks around / please.
OK.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-05 15:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 13:44 [PATCH v2 0/6] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2016-03-29 13:44 ` [PATCH v2 1/6] public/xen.h: add flags field to vcpu_time_info Joao Martins
2016-03-30 15:49 ` Ian Jackson
2016-03-30 16:33 ` Joao Martins
2016-03-31 7:09 ` Jan Beulich
2016-03-31 7:13 ` Jan Beulich
2016-03-31 11:04 ` Joao Martins
2016-04-05 10:16 ` Jan Beulich
2016-04-05 10:59 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 2/6] x86/time: refactor init_platform_time() Joao Martins
2016-04-01 16:10 ` Konrad Rzeszutek Wilk
2016-04-01 18:26 ` Joao Martins
2016-04-05 10:09 ` Jan Beulich
2016-04-05 10:55 ` Joao Martins
2016-04-05 11:16 ` Jan Beulich
2016-03-29 13:44 ` [PATCH v2 3/6] x86/time: implement tsc as clocksource Joao Martins
2016-03-29 17:39 ` Konrad Rzeszutek Wilk
2016-03-29 17:52 ` Joao Martins
2016-04-01 16:43 ` Konrad Rzeszutek Wilk
2016-04-01 18:38 ` Joao Martins
2016-04-01 18:45 ` Konrad Rzeszutek Wilk
2016-04-03 18:47 ` Joao Martins
2016-04-05 10:43 ` Jan Beulich
2016-04-05 14:56 ` Joao Martins
2016-04-05 15:12 ` Jan Beulich
2016-04-05 17:07 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 4/6] x86/time: streamline platform time init on plt_init() Joao Martins
2016-04-05 11:46 ` Jan Beulich
2016-04-05 15:12 ` Joao Martins [this message]
2016-04-05 15:22 ` Jan Beulich
2016-04-05 17:17 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 5/6] x86/time: refactor read_platform_stime() Joao Martins
2016-04-01 18:32 ` Konrad Rzeszutek Wilk
2016-04-05 11:52 ` Jan Beulich
2016-04-05 15:22 ` Joao Martins
2016-04-05 15:26 ` Jan Beulich
2016-04-05 17:08 ` Joao Martins
2016-03-29 13:44 ` [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2016-04-05 12:22 ` Jan Beulich
2016-04-05 21:34 ` Joao Martins
2016-04-07 15:58 ` Jan Beulich
2016-04-07 21:17 ` Joao Martins
2016-04-07 21:32 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703D5F4.6040901@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).