* [PATCH] xen/apic: Update the comment for apic_id_mask
@ 2016-07-07 3:28 Wei Jiangang
0 siblings, 0 replies; 5+ messages in thread
From: Wei Jiangang @ 2016-07-07 3:28 UTC (permalink / raw)
To: linux-kernel; +Cc: x86, mingo, hpa, xen-devel, tglx, Wei Jiangang
verify_local_APIC() had been removed by
commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
so apic_id_mask isn't used by it.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
arch/x86/xen/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
index db52a7fafcc2..9cbb1f48381b 100644
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
.get_apic_id = xen_get_apic_id,
.set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
- .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
+ .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
.cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
--
1.9.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com>]
* Re: [PATCH] xen/apic: Update the comment for apic_id_mask
[not found] <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com>
@ 2016-07-07 15:25 ` Konrad Rzeszutek Wilk
[not found] ` <20160707152510.GJ17766@localhost.localdomain>
1 sibling, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-07 15:25 UTC (permalink / raw)
To: Wei Jiangang, boris.ostrovsky, david.vrabel
Cc: x86, linux-kernel, mingo, hpa, xen-devel, tglx
On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
> verify_local_APIC() had been removed by
> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
> so apic_id_mask isn't used by it.
CC-ing the proper maintainers.
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> arch/x86/xen/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
> index db52a7fafcc2..9cbb1f48381b 100644
> --- a/arch/x86/xen/apic.c
> +++ b/arch/x86/xen/apic.c
> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>
> .get_apic_id = xen_get_apic_id,
> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>
> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>
> --
> 1.9.3
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <20160707152510.GJ17766@localhost.localdomain>]
* Re: [PATCH] xen/apic: Update the comment for apic_id_mask
[not found] ` <20160707152510.GJ17766@localhost.localdomain>
@ 2016-07-07 15:37 ` Boris Ostrovsky
2016-07-13 7:56 ` Wei, Jiangang
[not found] ` <1468396427.2020.14.camel@localhost>
0 siblings, 2 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2016-07-07 15:37 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Wei Jiangang, david.vrabel
Cc: Juergen Gross, x86, linux-kernel, mingo, hpa, xen-devel, tglx
On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
>> verify_local_APIC() had been removed by
>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
>> so apic_id_mask isn't used by it.
Is anyone actually using this field? It looks like 4399c03c6780 removed
the only user.
-boris
> CC-ing the proper maintainers.
>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>> ---
>> arch/x86/xen/apic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
>> index db52a7fafcc2..9cbb1f48381b 100644
>> --- a/arch/x86/xen/apic.c
>> +++ b/arch/x86/xen/apic.c
>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>>
>> .get_apic_id = xen_get_apic_id,
>> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
>> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
>> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>>
>> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>>
>> --
>> 1.9.3
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] xen/apic: Update the comment for apic_id_mask
2016-07-07 15:37 ` Boris Ostrovsky
@ 2016-07-13 7:56 ` Wei, Jiangang
[not found] ` <1468396427.2020.14.camel@localhost>
1 sibling, 0 replies; 5+ messages in thread
From: Wei, Jiangang @ 2016-07-13 7:56 UTC (permalink / raw)
To: boris.ostrovsky
Cc: jgross, x86, linux-kernel, mingo, david.vrabel, hpa, xen-devel, tglx
On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote:
> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
> > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
> >> verify_local_APIC() had been removed by
> >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
> >> so apic_id_mask isn't used by it.
>
> Is anyone actually using this field? It looks like 4399c03c6780 removed
> the only user.
Indeed, the field is useless.
Maybe we can remove this field from the struct apic .
what's your opinion?
Thanks,
wei
>
> -boris
>
>
> > CC-ing the proper maintainers.
> >> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> >> ---
> >> arch/x86/xen/apic.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
> >> index db52a7fafcc2..9cbb1f48381b 100644
> >> --- a/arch/x86/xen/apic.c
> >> +++ b/arch/x86/xen/apic.c
> >> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
> >>
> >> .get_apic_id = xen_get_apic_id,
> >> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
> >> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
> >> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
> >>
> >> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
> >>
> >> --
> >> 1.9.3
> >>
> >>
> >>
> >>
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xen.org
> >> https://lists.xen.org/xen-devel
>
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <1468396427.2020.14.camel@localhost>]
* Re: [PATCH] xen/apic: Update the comment for apic_id_mask
[not found] ` <1468396427.2020.14.camel@localhost>
@ 2016-07-13 18:51 ` Boris Ostrovsky
0 siblings, 0 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2016-07-13 18:51 UTC (permalink / raw)
To: Wei, Jiangang
Cc: jgross, x86, linux-kernel, mingo, david.vrabel, hpa, xen-devel, tglx
On 07/13/2016 03:56 AM, Wei, Jiangang wrote:
> On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote:
>> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
>>> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
>>>> verify_local_APIC() had been removed by
>>>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
>>>> so apic_id_mask isn't used by it.
>> Is anyone actually using this field? It looks like 4399c03c6780 removed
>> the only user.
> Indeed, the field is useless.
> Maybe we can remove this field from the struct apic .
> what's your opinion?
Since noone seems to be using those I think it can be removed.
-boris
>
> Thanks,
> wei
>> -boris
>>
>>
>>> CC-ing the proper maintainers.
>>>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>>>> ---
>>>> arch/x86/xen/apic.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
>>>> index db52a7fafcc2..9cbb1f48381b 100644
>>>> --- a/arch/x86/xen/apic.c
>>>> +++ b/arch/x86/xen/apic.c
>>>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>>>>
>>>> .get_apic_id = xen_get_apic_id,
>>>> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
>>>> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
>>>> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>>>>
>>>> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>>>>
>>>> --
>>>> 1.9.3
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@lists.xen.org
>>>> https://lists.xen.org/xen-devel
>>
>>
>>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-13 18:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-07 3:28 [PATCH] xen/apic: Update the comment for apic_id_mask Wei Jiangang
[not found] <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com>
2016-07-07 15:25 ` Konrad Rzeszutek Wilk
[not found] ` <20160707152510.GJ17766@localhost.localdomain>
2016-07-07 15:37 ` Boris Ostrovsky
2016-07-13 7:56 ` Wei, Jiangang
[not found] ` <1468396427.2020.14.camel@localhost>
2016-07-13 18:51 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).